Date: Tue, 10 Oct 2006 10:40:26 GMT From: Yar Tikhiy <yar@comp.chem.msu.su> To: freebsd-rc@FreeBSD.org Subject: Re: bin/104044: [patch] rc.d/cleartmp works incorrectly Message-ID: <200610101040.k9AAeQgM012240@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/104044; it has been noted by GNATS.
From: Yar Tikhiy <yar@comp.chem.msu.su>
To: Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
Cc: Florent Thoumie <flz@xbsd.org>, bug-followup@freebsd.org
Subject: Re: bin/104044: [patch] rc.d/cleartmp works incorrectly
Date: Tue, 10 Oct 2006 14:34:43 +0400
On Tue, Oct 10, 2006 at 11:26:38AM +0300, Andrey Simonenko wrote:
> Another updated version:
>
> 1. Everything, what belongs to _start method, was moved to
> cleartmp_start().
Thanks!
> 2. Ignore error code from rm and always run find, that is
> use "rm ... ; find ..." instead of "rm ... && find ...":
> one can create many files with long names and rm will not
> be called because of "Argument list too long" error, so
> find should do all of the work.
By the way, did you consider omitting the first rm at all and just
using "find ... -print0 | xargs -0 rm -rf" ? The first rm can be
an optimization as long as we use find with -exec. OTOH, xargs -0
would buy us the same performance and robustness without hacks.
Both find and xargs should be available to cleartmp. Here's the
code. Note "type -d" omitted.
if checkyesno ${rcvar1}; then
# This is not needed with mfs /tmp, but doesn't hurt anything.
echo "Clearing /tmp."
find -x /tmp/. ! -name . \
! \( -name lost+found -type d -user root \) \
! \( \( -name quota.user -or -name quota.group \) \
-type f -user root \) \
-prune -print0 | xargs -0 rm -rf
elif ...
Another thought of mine was that cleartmp wouldn't handle files with
an immutable flag set. Fortunately, rm -f appears to take care of
files with uchg while those with schg on them should be left alone.
So flags aren't an issue.
--
Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610101040.k9AAeQgM012240>