From owner-freebsd-current@FreeBSD.ORG  Mon Nov 21 19:27:11 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1CB8716A41F;
	Mon, 21 Nov 2005 19:27:11 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 63A3B43D49;
	Mon, 21 Nov 2005 19:27:10 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1] (may be forged))
	by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id jALJOeaV045045;
	Mon, 21 Nov 2005 12:24:40 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Mon, 21 Nov 2005 12:24:40 -0700 (MST)
Message-Id: <20051121.122440.85370117.imp@bsdimp.com>
To: jhb@freebsd.org
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <200511211307.05043.jhb@freebsd.org>
References: <20051120042536.E72D816A421@hub.freebsd.org>
	<20051120.210457.109704843.imp@bsdimp.com>
	<200511211307.05043.jhb@freebsd.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Mon, 21 Nov 2005 12:24:41 -0700 (MST)
Cc: wpaul@freebsd.org, craig@xfoil.gank.org, freebsd-current@freebsd.org,
	current@freebsd.org, tillman@seekingfire.com
Subject: Re: Compaq ProLiant 1600 server freezes when detecting keyboard
 controller
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Nov 2005 19:27:11 -0000

From: John Baldwin <jhb@freebsd.org>
Subject: Re: Compaq ProLiant 1600 server freezes when detecting keyboard controller
Date: Mon, 21 Nov 2005 13:07:02 -0500

> On Sunday 20 November 2005 11:04 pm, M. Warner Losh wrote:
> > In message: <20051120042536.E72D816A421@hub.freebsd.org>
> >
> >             wpaul@freebsd.org (Bill Paul) writes:
> > : Our PCI code
> > : then comes along and enables all of the devices but doesn't necessarily
> > : update the base address registers on some of them, which has the effect
> > : of mapping one of the PCI devices at physical address 0.
> >
> > Actually, that bug has been fixed in recent versions of
> > FreeBSD-current, and should be fixed in 6.0.  I recall merging changes
> > to 6.0 just before the release.  The problem was that the host bridge
> > wasn't properly setting a range.  If that's not the case, then I'd
> > like to know about it...
> 
> No, the bug was fixed, but that wasn't the fix.  The fix was to bail out 
> earlier if a BAR's base was 0 and not enable IO or MEM decoding unless a BAR 
> had a valid base (where 0 and 0xfffffff are both invalid bases).

Ah, that's the other bug we fixed...

Warner