From owner-cvs-src@FreeBSD.ORG Thu May 22 17:02:23 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4EEAA106564A; Thu, 22 May 2008 17:02:23 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 1BAA58FC28; Thu, 22 May 2008 17:02:23 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m4MH2MCU035278 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 May 2008 10:02:22 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <4835A71E.3030703@freebsd.org> Date: Thu, 22 May 2008 10:02:22 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: Maxim Sobolev References: <200805221440.m4MEe32W039559@repoman.freebsd.org> <4835A619.3010502@FreeBSD.org> In-Reply-To: <4835A619.3010502@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC--Metrics: ebb.errno.com; whitelist Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Ed Schouten , cvs-all@freebsd.org Subject: Re: cvs commit: src/share/man/man3 Makefile queue.3 src/sys/sys queue.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2008 17:02:23 -0000 Maxim Sobolev wrote: > Ed Schouten wrote: >> The OpenBSD version of SLIST_REMOVE_NEXT() needs a reference to the >> list >> head, even though it is unused. > > I don't think it's necessary. sys/queue.h API is not supposed to be > portable across different operating systems. The need to pass list > head around may impede macro usefulness. Gratuitous differences impede porting. If it's not a big deal then maintain compatibility. We already have stupid differences in various areas that must be papered over when code is brokered between systems. Sam