From owner-freebsd-stable@FreeBSD.ORG Mon May 3 08:39:27 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E4CC11065670 for ; Mon, 3 May 2010 08:39:27 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp109.plus.mail.re1.yahoo.com (smtp109.plus.mail.re1.yahoo.com [69.147.102.72]) by mx1.freebsd.org (Postfix) with SMTP id 85CFC8FC18 for ; Mon, 3 May 2010 08:39:27 +0000 (UTC) Received: (qmail 19312 invoked from network); 3 May 2010 08:39:26 -0000 Received: from [10.142.15.240] (se@80.187.209.46 with plain) by smtp109.plus.mail.re1.yahoo.com with SMTP; 03 May 2010 01:39:26 -0700 PDT X-Yahoo-SMTP: iDf2N9.swBDAhYEh7VHfpgq0lnq. X-YMail-OSG: pcdt3BcVM1kb2IPRG4f1NDKbnX4astDqCtAZL.YJVNMRyj3 txPUHxt23B1cWk1P8EuwZzKZB2mYY76gmZOeeqHRIYF8X.6p5Y12LI7qyTXC jNbYT.pvFfHG49zFFRkzW7tQXVs3n4SwhJzP2LkLu2osFH95CmOUJpyHQ1Pt 75WnIC4IiuMj0v5or6ZbVS5HcWIVgmrmcVT8Bul9gySPfHydofOBvpnyzDRq NF9TGjUSRUakjsRnWZhng_Bflo3.aNslGC_3BjBn14LTKZdaw99WCTFHCvuD QBjWLM45Bsos- X-Yahoo-Newman-Property: ymail-3 Message-ID: <4BDE8BBF.10603@FreeBSD.org> Date: Mon, 03 May 2010 10:39:27 +0200 From: Stefan Esser User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.18) Gecko/20081105 Thunderbird/2.0.0.18 ThunderBrowse/3.2.2.1 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: freebsd-stable@freebsd.org References: <4B28F841.1070900@skylinetele.com> <4BD54AC7.7090301@FreeBSD.org> <4BD5B91B.2050606@elischer.org> In-Reply-To: <4BD5B91B.2050606@elischer.org> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: net/mpd5, ppp, proxy-arp issues X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 May 2010 08:39:28 -0000 Am 26.04.2010 18:02, schrieb Julian Elischer: > On 4/26/10 1:11 AM, Stefan Esser wrote: >> I debugged this problem and prepared a patch for discussion, which >> later was committed by Max Laier (if memory serves me right). The >> message was added in order to identify further situations, where >> network domains are added after network interfaces have been >> initialized. This message ought to be informational right now, since >> the interface init is repeated whenever a network domain is added >> as part of above mentioned patch. Init order should be fixed, if >> this message is printed for compiled in drivers, but in case of a >> kernel module (like netgraph) that adds a domain, it is unadvoidable >> that the init order is reversed. >> >> Perhaps the message should be made conditional on the start-up of >> the kernel not having finished, or it should be completely removed, >> since time has shown, that the init order is correct in general. >> >> I'll remove that message (or make it conditional on "bootverbose") >> unless there is opposition to this change ... > please do.. > > it's an unavoidable thing that domains added after boot > are done after boot completes :-) Hmmm, I had a look at the code over the weekend and I'm not sure, whether changes during the last 5 years did not break assumptions and introduced bugs in if_attachdomain1() in /sys/net/if.c ... The tests at the head of the function seem problematic, but will need further analysis. I'll have to check the conditions under which the TRY_LOCK may fail and the second if clause seems to prevent the execution of the core of the function for KLDs (which would be BAD). Since I'm travelling abroad and without access to the sources or a test system for most of the week, I cannot perform these tests. But I'd be very surprised, if the code still worked as I intended it more than 5 years ago ... I'll hold back any commits until I have been able to perform tests (or somebody else looks into this and gets to a conclusion ...). Best regards, STefan