Date: Tue, 6 Apr 2004 11:33:29 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Lukas Ertl <le@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/growfs Makefile debug.c growfs.c Message-ID: <20040406113129.T28582@root.org> In-Reply-To: <20040406194620.P631@korben> References: <200404031740.i33HeKH6016345@repoman.freebsd.org> <20040403184246.GA613@darkness.comp.waw.pl> <20040406194620.P631@korben>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 6 Apr 2004, Lukas Ertl wrote: > On Sat, 3 Apr 2004, Pawel Jakub Dawidek wrote: > > > On Sat, Apr 03, 2004 at 09:40:20AM -0800, Lukas Ertl wrote: > > +> le 2004/04/03 09:40:20 PST > > +> > > +> FreeBSD src repository > > +> > > +> Modified files: > > +> sbin/growfs Makefile debug.c growfs.c > > +> Log: > > +> Make growfs WARNS=6 clean. > > > > AFAIK growfs(8) doesn't work with UFS2, so maybe while you are here... :) > > It works on UFS2, but not very well. Yes, I'll have a look, but maybe > I'll make a big style sweep first, so I can actually read what's going on > there. :-) It does work but there are problems. First thing that should be done is factor out the superblock update code and have growfs bring it up to canonical (latest) form before processing the fs. Also, there are minor things like it removing flags like ACLs from the superblock. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040406113129.T28582>