From owner-cvs-all@FreeBSD.ORG  Sun Dec  5 22:19:48 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D1BC016A542; Sun,  5 Dec 2004 22:19:48 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 33ADC43D41; Sun,  5 Dec 2004 22:19:48 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iB5MJdrf068312;
	Sun, 5 Dec 2004 23:19:39 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Nate Lawson <nate@root.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 05 Dec 2004 14:16:38 PST."
             <41B388C6.5090409@root.org> 
Date: Sun, 05 Dec 2004 23:19:39 +0100
Message-ID: <68311.1102285179@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: "M. Warner Losh" <imp@bsdimp.com>
Subject: Re: cvs commit: src/sys/dev/acpica acpi.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Dec 2004 22:19:49 -0000

In message <41B388C6.5090409@root.org>, Nate Lawson writes:
>M. Warner Losh wrote:
>> In message: <200412050135.iB51ZJJl040909@repoman.freebsd.org>
>>             Nate Lawson <njl@FreeBSD.org> writes:
>> :   If we are resuming non-MPSAFE drivers, they need Giant held for them.
>> 
>> Generally, when walking the device tree, one must have Giant.  I've
>> been meaning to add asserts for this in the tree...  I think that we
>> have enough things giant is pushed out of that it is time...
>
>I'd like that.  I think the GIANT_REQUIRED asserts should go in the 
>root_bus suspend/resume/shutdown methods, not in acpi.  This will cover 
>everyone unless a driver drops Giant and doesn't reacquire it (unlikely).

In Geom I assert after I call driver methods, just to catch that case
as well.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.