Date: Wed, 10 Apr 2002 07:50:04 -0700 (PDT) From: Mike Barcroft <mike@FreeBSD.org> To: freebsd-standards@FreeBSD.org Subject: Re: standards/36950: Add -n to renice(8) Message-ID: <200204101450.g3AEo4k99545@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR standards/36950; it has been noted by GNATS.
From: Mike Barcroft <mike@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:
Subject: Re: standards/36950: Add -n to renice(8)
Date: Wed, 10 Apr 2002 10:41:49 -0400
Tim J. Robbins <tim@robbins.dropbear.id.au> writes:
> On Wed, Apr 10, 2002 at 04:16:02AM -0000, Peter Avalos wrote:
>
> > Index: renice.c
> > ===================================================================
>
> > -static const char copyright[] =
> > +static char copyright[] =
>
> I believe this should stay const. You could consider using the __COPYRIGHT
> macro, but \n's in its argument don't work properly.
Vendor copyrights should be left in their original form. Adding
`const' here is a necessary evil in order prevent diagnostics on
modern compilers.
> > - printf("%d: old priority %d, new priority %d\n", who, oldprio, prio);
> > + printf("%d: old nice_value %d, new nice_value %d\n", who, oldprio,
+prio);
>
> This should just be removed alltogether - SUSv3 specifies that standard
> output is not used at all, despite this being traditional behaviour.
I'm not sure of the impact to the existing userbase, but I agree that
this diagnostic is very unbecoming (particularly since it's outputted
to stdout instead of stderr).
Best regards,
Mike Barcroft
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-standards" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204101450.g3AEo4k99545>