Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 4 May 2019 12:24:02 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Matthias Andree <mandree@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r500805 - in head/graphics/exact-image: . files
Message-ID:  <20190504122402.GA46020@FreeBSD.org>
In-Reply-To: <201905041143.x44BhE4d051108@repo.freebsd.org>
References:  <201905041143.x44BhE4d051108@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 04, 2019 at 11:43:14AM +0000, Matthias Andree wrote:
> New Revision: 500805
> URL: https://svnweb.freebsd.org/changeset/ports/500805
> 
> Log:
>   Upgrade to new upstream release 1.0.2.

Thanks.  I was planning doing this as well, but you've beaten me.
One minor observation (press PgDn).

> Modified: head/graphics/exact-image/files/patch-api-api.cc
> ==============================================================================
> --- head/graphics/exact-image/files/patch-api-api.cc	Sat May  4 11:02:16 2019	(r500804)
> +++ head/graphics/exact-image/files/patch-api-api.cc	Sat May  4 11:43:14 2019	(r500805)
> @@ -1,6 +1,6 @@
> ---- api/api.cc.orig	2009-06-15 14:39:45.000000000 +0400
> -+++ api/api.cc	2014-01-13 07:25:57.460488862 +0400
> -@@ -909,7 +909,7 @@
> +--- api/api.cc.orig	2009-06-15 10:39:45 UTC
> ++++ api/api.cc
> +@@ -909,7 +909,7 @@ char** imageDecodeBarcodes (Image* image, const char* 
>     }
>     
>     std::vector<std::string> ret;
> 
> Modified: head/graphics/exact-image/files/patch-build__bottom.make
> ==============================================================================
> --- head/graphics/exact-image/files/patch-build__bottom.make	Sat May  4 11:02:16 2019	(r500804)
> +++ head/graphics/exact-image/files/patch-build__bottom.make	Sat May  4 11:43:14 2019	(r500805)
> @@ -1,6 +1,6 @@
> ---- build/bottom.make.orig	2010-07-22 18:35:17.000000000 +0400
> -+++ build/bottom.make	2014-12-12 00:07:13.000000000 +0300
> -@@ -43,23 +43,23 @@
> +--- build/bottom.make.orig	2018-05-03 16:50:06 UTC
> ++++ build/bottom.make
> +@@ -43,23 +43,23 @@ $(X_MODULE): $($(X_MODULE)_BINARY)
>   
>   $($(X_MODULE)_OUTPUT)/%.o: $(X_MODULE)/%.c
>   	@echo '  C         $@'

Please, avoid comitting patches when changes are only in the header
or context.  This greatly helps to keep the whole diff cleaner and
less noisy.  Thanks,

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190504122402.GA46020>