Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 04 Sep 2011 12:22:35 +0200
From:      Matthias Andree <mandree@FreeBSD.org>
To:        Ivan Klymenko <fidaj@ukr.net>
Cc:        freebsd-ports@FreeBSD.org
Subject:   Re: [ANNOUNCE]: clang compiling ports, take 2
Message-ID:  <4E63516B.7000805@FreeBSD.org>
In-Reply-To: <20110904114550.71c63078@nonamehost.>
References:  <20110725155920.GA83490@freebsd.org>	<4E631DBF.9000106@yandex.ru>	<20110904101252.526de5ef@nonamehost.>	<4E632A09.8060904@FreeBSD.org> <20110904114550.71c63078@nonamehost.>

next in thread | previous in thread | raw e-mail | index | archive | help
Am 04.09.2011 10:45, schrieb Ivan Klymenko:
> В Sun, 04 Sep 2011 09:34:33 +0200
> Matthias Andree <mandree@FreeBSD.org> пишет:
> 
>> Am 04.09.2011 09:12, schrieb Ivan Klymenko:
>>
>>> Maybe this will help:
>>> *rdup_entry = *rdup_entry;
>>
>> This is just guessing and probably triggers the same warning unless
>> it's volatile.
>>
>> Have the original author look at it.
> 
> This is not guesswork.

It is DANGEROUS guesswork. Assigning stuff to itself is pointless, so
this is a code bug.

The only valid exception I know is if you're writing back data to a
command register in a peripheral device, which isn't the case here.

Fix the bug, not the symptom!



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E63516B.7000805>