From owner-freebsd-ports Mon Sep 23 23:21:08 1996 Return-Path: owner-ports Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA15785 for ports-outgoing; Mon, 23 Sep 1996 23:21:08 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id XAA15757; Mon, 23 Sep 1996 23:21:02 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.6/8.6.9) with ESMTP id XAA03228; Mon, 23 Sep 1996 23:21:01 -0700 (PDT) To: asami@freebsd.org (Satoshi Asami) cc: andreas@freebsd.org, ports@freebsd.org Subject: Re: cvs commit: ports/graphics/xv Makefile In-reply-to: Your message of "Mon, 23 Sep 1996 22:42:55 PDT." <199609240542.WAA17114@silvia.HIP.Berkeley.EDU> Date: Mon, 23 Sep 1996 23:21:01 -0700 Message-ID: <3226.843546061@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-ports@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > * Added pre-clean target. > * When doing 'make clean' then clean tiff and jpeg as well. > > Um, I don't think this is a good idea. If we start adding pre-clean > targets for regular dependencies (LIB_DEPENDS and friends), our > Makefiles will be a mess.... > > If this is really needed, we can add it to bsd.port.mk. But not in > individual Makefiles. Yeah, I've commented on this in the past - our clean rule should follow the same dependencies which would have been traversed in building the port. Right now, you can do: make all install && make clean In many ports and wind up with far more bits on your disk than when you started due to depended ports being built but not cleaned again. I'd say it's a "bug" for bsd.port.mk to fix and not something the ports should be doing on their own, definitely. Jordan