Date: Tue, 20 Jul 2010 12:46:34 +0200 From: Hans Petter Selasky <hselasky@c2i.net> To: PseudoCylon <moonlightakkiy@yahoo.ca> Cc: Sam Leffler <sam@freebsd.org>, freebsd-current@freebsd.org, freebsd-usb@freebsd.org Subject: Re: [panic] Race in IEEE802.11 layer towards device drivers Message-ID: <201007201246.34654.hselasky@c2i.net> In-Reply-To: <504334.98385.qm@web51801.mail.re2.yahoo.com> References: <201007141511.46190.hselasky@c2i.net> <201007192117.05034.hselasky@c2i.net> <504334.98385.qm@web51801.mail.re2.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 20 July 2010 12:03:22 PseudoCylon wrote: > ----- Original Message ---- > > > From: Hans Petter Selasky <hselasky@c2i.net> > > To: freebsd-current@freebsd.org > > Cc: PseudoCylon <moonlightakkiy@yahoo.ca>; Sam Leffler <sam@freebsd.org>; > > > >freebsd-usb@freebsd.org > > > > Sent: Mon, July 19, 2010 1:17:04 PM > > Subject: Re: [panic] Race in IEEE802.11 layer towards device drivers > > > > Hi AK, > > > > I've committed your patches to USB P4. I've made some additional > > patches. > > > > Can you check and verify everything? > > > > http://p4web.freebsd.org/@@181189?ac=10 > > Hi > > If we change sc->cmdq_run = RUN_CMDQ_ABORT, > > -- begin excerpt -- > > > @@ -4890,7 +4877,10 @@ run_stop(void *arg) > ifp->if_drv_flags &= ~(IFF_DRV_RUNNING | IFF_DRV_OACTIVE); > > sc->ratectl_run = RUN_RATECTL_OFF; > -sc->cmdq_run = RUN_CMDQ_ABORT; > + > +RUN_CMDQ_LOCK(sc); > +sc->cmdq_run = sc->cmdq_key_set = RUN_CMDQ_ABORT; > +RUN_CMDQ_UNLOCK(sc); > > -- end excerpt -- > > > we also need to change this, otherwise key will be cleared. Ok. Try to give the second mutex a different name, and see how many warnings go away. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007201246.34654.hselasky>