From owner-freebsd-current@freebsd.org Thu Apr 12 20:28:24 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B48C6F8E375 for ; Thu, 12 Apr 2018 20:28:24 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A5F96A69E; Thu, 12 Apr 2018 20:28:24 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 0D0CFBC5A; Thu, 12 Apr 2018 20:28:24 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 3F198BFF; Thu, 12 Apr 2018 20:28:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id p8ts_YpRFkm4; Thu, 12 Apr 2018 20:28:20 +0000 (UTC) Subject: Re: Module compiles looking in /usr/src when alternate src tree is in use DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com B70A4BFA From: Bryan Drewery To: "Rodney W. Grimes" , "Simon J. Gerraty" Cc: freebsd-current@freebsd.org References: <201804110029.w3B0TPUf025467@pdx.rh.CN85.dnsmgr.net> <115747a8-a7f9-9112-d7b0-c4fc24742708@FreeBSD.org> Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Thu, 12 Apr 2018 13:28:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6WCvRrcXi3sTZG30t6JNBw96gELIZIgRi" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 20:28:25 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6WCvRrcXi3sTZG30t6JNBw96gELIZIgRi Content-Type: multipart/mixed; boundary="5ftsNCKK7euUYYCGLAbqTQWsCvx4B4NKf"; protected-headers="v1" From: Bryan Drewery To: "Rodney W. Grimes" , "Simon J. Gerraty" Cc: freebsd-current@freebsd.org Message-ID: Subject: Re: Module compiles looking in /usr/src when alternate src tree is in use References: <201804110029.w3B0TPUf025467@pdx.rh.CN85.dnsmgr.net> <115747a8-a7f9-9112-d7b0-c4fc24742708@FreeBSD.org> In-Reply-To: --5ftsNCKK7euUYYCGLAbqTQWsCvx4B4NKf Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/12/2018 1:20 PM, Bryan Drewery wrote: > On 4/12/2018 1:11 PM, Bryan Drewery wrote: >> On 4/10/2018 5:29 PM, Rodney W. Grimes wrote: >>>> Rodney W. Grimes wrote: >>>> >>>>> I am having a compile time issue for a patched that compiled fine o= n my >>>>> r329294 system, but now failes to compile with what looks like a wr= ong >>>>> header being included. >>>> >>>> You may find it helpful to do something like: >>>> >>>> make -dv -C sys/modules/vmm -V CFLAGS > /tmp/dvo 2>&1 >>>> egrep ':.PARSE|/usr/src/sys' /tmp/dvo | grep -B1 usr/src | more >>>> >>>> The arg to -V doesn't matter btw. >>>> You could narrow that down if you know what var -I/usr/src/sys is in= >>>> (probably CFLAGS but you never know) >>>> the above should help find the makefile that is introducing the bogu= s -I >>>> >>> >>> Thank you, that does help narrow it down: (I backed up a vew lines >>> from the first place I saw src/.) >>> >>> ... >>> Global:.PARSEFILE =3D bsd.kmod.mk >>> Global:.PARSEDIR =3D /usr/src-topo/share/mk >>> Global:.PARSEFILE =3D bsd.kmod.mk >>> Result[] of :U is "/usr/src/sys" >>> Result[] of :U is "/usr/src/sys" >>> Global:SYSDIR =3D ${:U/usr/src/sys:tA} >>> Global:.PARSEDIR =3D /usr/src-topo/share/mk >>> Global:.PARSEFILE =3D bsd.kmod.mk >>> Result[] of :U is "/usr/src/sys" >>> Applying[] :t to "/usr/src/sys" >>> Result[] of :t is "/usr/src/sys" >>> Result[] of :U is "/usr/src/sys" >>> Applying[] :t to "/usr/src/sys" >>> Result[] of :t is "/usr/src/sys" >>> Result[] of :U is "/usr/src/sys" >>> Applying[] :t to "/usr/src/sys" >>> Result[] of :t is "/usr/src/sys" >>> Global:.MAKE.MAKEFILES =3D /usr/src-topo/share/mk/sys.mk /usr/src-top= o/share/mk/local.sys.env.mk /usr/src-topo/share/mk/src.sys.env.mk /usr/sr= c-topo/share/mk/bsd.mkopt.m >>> k /usr/src-topo/share/mk/src.sys.obj.mk /usr/src-topo/share/mk/auto.o= bj.mk /usr/src-topo/share/mk/bsd.suffixes.mk /usr/src-topo/share/mk/local= =2Esys.mk /usr/src-topo/sha >>> re/mk/src.sys.mk /usr/src-topo/sys/modules/vmm/Makefile /usr/src-topo= /share/mk/bsd.kmod.mk /usr/src/sys/conf/kmod.mk >>> = ^^^^^^^^^^^^^^^^^^^^^^^^^ >>> Thats gona bust something some day.... >>> >>> Global:.PARSEDIR =3D /usr/src/sys/conf >>> Global:.PARSEFILE =3D kmod.mk >>> Global:.INCLUDEDFROMDIR =3D /usr/src/sys/conf >>> Oh my! Uggggg >>> >>> >>> So something in bsd.kmod.mk is going very wrong... it looks like it >>> starts to pull all sorts of stuff from /usr/src/sys! >>> >>>>> >>>>> I have wrapped the long line so I can point to a difference between= >>>>> r329294 and r332262 make log of this file. >>>>> >>>>> r329294 make output: >>>>> >>>>> cc -O2 -pipe -DVMM_KEEP_STATS -DSMP -fno-strict-aliasing -Werror = -D_KERNEL \ >>>>> -DKLD_MODULE -nostdinc -I/usr/src-topo/sys/amd64/vmm \ >>>>> -I/usr/src-topo/sys/amd64/vmm/io -I/usr/src-topo/sys/amd64/vmm/inte= l \ >>>>> -I/usr/src-topo/sys/amd64/vmm/amd -I. -I/usr/src-topo/sys -fno-comm= on \ >>>>> ^^^^^^^^^^^^^^^^^ this is wh= at I would expect >>>> >>>> >>> >> >> Is this buildkernel or a direct module directory build? >> >> Does reverting r331683 and r331682 help? Perhaps I missed ensuring >> SYSDIR is exported properly. >> >=20 > Ok I see the problem with a direct module build. I am fixing it. Sorry > about that. >=20 Fixed in r332453. --=20 Regards, Bryan Drewery --5ftsNCKK7euUYYCGLAbqTQWsCvx4B4NKf-- --6WCvRrcXi3sTZG30t6JNBw96gELIZIgRi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaz8FiAAoJEDXXcbtuRpfP5TQH/3z2rm9L0xgmlNGDWIKo7eBt kfXUDIuTV5Gj8bPr8byJUU67xysSfMO8II6p2nc7/eG3lT18d2N8brPR06cdwwtL 6TV7NVWacEs29A1aFd0jvAkPVWCgrUSJRhiMAj80SueBfJ2smYxhc4Lbr5PG0AJs U+LMgDZT9LB/jfkMNf5x3sTnLd5o2Yi0ltm4hq24GpCwtgPrUpmmTwohd4mZwYm5 HVZuHw/O5ut3/XgIDf6IvaGGDfr4EbD2tr53z+60RMar915I2CS0Wj8gfG0XRmQR rwq0TAW29/WOQYoQXPriX143BSUzWt6Udjw1qfwrp+cHScqrjitvUEqZ1j6oY78= =9bfx -----END PGP SIGNATURE----- --6WCvRrcXi3sTZG30t6JNBw96gELIZIgRi--