From owner-freebsd-current@FreeBSD.ORG  Tue Jun  9 07:45:58 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E9183106566B;
	Tue,  9 Jun 2009 07:45:58 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.16.84])
	by mx1.freebsd.org (Postfix) with ESMTP id A25F48FC29;
	Tue,  9 Jun 2009 07:45:58 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from pampa.cs.huji.ac.il ([132.65.80.32])
	by kabab.cs.huji.ac.il with esmtp
	id 1MDvQt-000CEr-B0; Tue, 09 Jun 2009 10:07:43 +0300
X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2
To: rea-fbsd@codelabs.ru
In-reply-to: <pnDviOUhM/SNuybQq0u/UHsbVeU@j4OYE6OL8eALCd4BvSxIfwgoxSc> 
References: <20090608224516.547F17302F@freebsd-current.sentex.ca> 
	<4A2DA390.3090704@delphij.net>
	<pnDviOUhM/SNuybQq0u/UHsbVeU@j4OYE6OL8eALCd4BvSxIfwgoxSc>
Comments: In-reply-to Eygene Ryabinkin <rea-fbsd@codelabs.ru>
	message dated "Tue, 09 Jun 2009 08:49:12 +0400."
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Tue, 09 Jun 2009 10:07:43 +0300
From: Danny Braniss <danny@cs.huji.ac.il>
Message-ID: <E1MDvQt-000CEr-B0@kabab.cs.huji.ac.il>
Cc: d@delphij.net, current@freebsd.org, net@freebsd.org
Subject: Re: [head tinderbox] failure on sparc64/sparc64 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jun 2009 07:45:59 -0000

> Xin, good day.
> 
> Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote:
> > The attached patch should fix this, any objections?
> 
> Yes, you missed negation operator in the copyin check.  The issue
> was already fixed by hrs@ two hours ago:
>   http://svn.freebsd.org/viewvc/base?view=revision&revision=193796
sorry to barge in, but:
           if ((options | GIF_FULLOPTS) == GIF_FULLOPTS)
is not clear,
	   if ((options & ~GIF_FULLOPTS) == 0)
seems to be less offuscated or I'm missing something?

danny
> -- 
> Eygene
>  _                ___       _.--.   #
>  \`.|\..----...-'`   `-._.-'_.-'`   #  Remember that it is hard
>  /  ' `         ,       __.--'      #  to read the on-line manual
>  )/' _/     \   `-_,   /            #  while single-stepping the kernel.
>  `-'" `"\_  ,_.-;_.-\_ ',  fsc/as   #
>      _.-'_./   {_.'   ; /           #    -- FreeBSD Developers handbook
>     {_.-``-'         {_/            #
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
>