Date: Tue, 20 Jan 2004 14:45:24 -0500 From: John Baldwin <jhb@FreeBSD.org> To: "Poul-Henning Kamp" <phk@phk.freebsd.dk> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h Message-ID: <200401201445.24897.jhb@FreeBSD.org> In-Reply-To: <8219.1074623036@critter.freebsd.dk> References: <8219.1074623036@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 20 January 2004 01:23 pm, Poul-Henning Kamp wrote: > In message <200401201234.45472.jhb@FreeBSD.org>, John Baldwin writes: > >On Monday 19 January 2004 04:27 pm, Poul-Henning Kamp wrote: > >> phk 2004/01/19 13:27:11 PST > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/alpha/alpha support.s > >> sys/i386/i386 swtch.s > >> sys/kern kern_shutdown.c > >> sys/sys systm.h > >> Log: > >> Add linenumber and source filename to panic(9) output. > >> > >> Ideally a traceback should be printed too, any takers ? > > > >We already print a traceback if DDB is in the kernel. > > The traceback doesn't make it into the msgbuffer, and therefore > many bug reports give no details. > > >We already print a traceback if DDB is in the kernel. Given that panic > >messages are already largely unique and greppable, I think this doesn't > >really buy us all that much. > > It saves the PR-washing team a lot of grepping. I doubt it. Most of the bug reports (and PR's) that I've worked on, the submitter usually doesn't provide the panic message at first anyways. Secondly, probably at least 80% of panics are page trap faults due to a null pointer dereference, and having a source file and line number for trap.c just serves as even more obfuscation of an already busy panic message for a fatal kernel trap. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401201445.24897.jhb>