From owner-freebsd-i386@FreeBSD.ORG Thu Jun 26 07:31:39 2008 Return-Path: Delivered-To: i386@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0D71106566C; Thu, 26 Jun 2008 07:31:39 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from postfix2-g20.free.fr (postfix2-g20.free.fr [212.27.60.43]) by mx1.freebsd.org (Postfix) with ESMTP id 448BB8FC13; Thu, 26 Jun 2008 07:31:39 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by postfix2-g20.free.fr (Postfix) with ESMTP id 2AC4F27A2AAD; Thu, 26 Jun 2008 06:59:50 +0200 (CEST) Received: from smtp5-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp5-g19.free.fr (Postfix) with ESMTP id 225A53F627A; Thu, 26 Jun 2008 09:00:07 +0200 (CEST) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id 168E93F63D6; Thu, 26 Jun 2008 08:59:56 +0200 (CEST) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id 51CDB9B497; Thu, 26 Jun 2008 06:55:26 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id 445B04089; Thu, 26 Jun 2008 08:55:26 +0200 (CEST) Date: Thu, 26 Jun 2008 08:55:26 +0200 From: Jeremie Le Hen To: FreeBSD Tinderbox Message-ID: <20080626065526.GE15815@obiwan.tataz.chchile.org> References: <20080626062043.19D1073039@freebsd-current.sentex.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080626062043.19D1073039@freebsd-current.sentex.ca> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: current@freebsd.org, i386@freebsd.org Subject: Re: [head tinderbox] failure on i386/i386 X-BeenThere: freebsd-i386@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: I386-specific issues for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2008 07:31:40 -0000 Hi, On Thu, Jun 26, 2008 at 02:20:43AM -0400, FreeBSD Tinderbox wrote: > vga_isa.o(.text+0x1f7): In function `isavga_probe': > : undefined reference to `__stack_chk_fail' > xboxfb.o(.text+0xa79): In function `xboxfb_diag': > : undefined reference to `__stack_chk_guard' > xboxfb.o(.text+0xb03): In function `xboxfb_diag': > : undefined reference to `__stack_chk_guard' > xboxfb.o(.text+0xb0a): In function `xboxfb_diag': > : undefined reference to `__stack_chk_fail' > *** Error code 1 This is my bad, sorry. Please apply the following patch: Index: sys/kern/stack_protector.c =================================================================== RCS file: /mnt/octobre/space/freebsd-cvs/src/sys/kern/stack_protector.c,v retrieving revision 1.1 diff -u -r1.1 stack_protector.c --- sys/kern/stack_protector.c 25 Jun 2008 21:33:28 -0000 1.1 +++ sys/kern/stack_protector.c 26 Jun 2008 06:57:11 -0000 @@ -7,7 +7,6 @@ #include #include -#if defined(__SSP__) || defined(__SSP_ALL__) long __stack_chk_guard[8] = {}; void __stack_chk_fail(void); @@ -31,5 +30,3 @@ } /* SI_SUB_EVENTHANDLER is right after SI_SUB_LOCK used by arc4rand() init. */ SYSINIT(stack_chk, SI_SUB_EVENTHANDLER, SI_ORDER_ANY, __stack_chk_init, NULL); - -#endif -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >