Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Jun 2011 08:33:51 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        "Ilya A. Arkhipov" <micro@heavennet.ru>
Cc:        Chris Rees <crees@freebsd.org>, ports@freebsd.org, Ion-Mihai Tetcu <itetcu@freebsd.org>, Joe Marcus Clarke <marcus@freebsd.org>, kwm@freebsd.org
Subject:   Re: portlint(1) knobs order: let's make things more logical
Message-ID:  <20110623083351.GA51681@FreeBSD.org>
In-Reply-To: <BANLkTi=fiYsp-fJY97TkTyXWOCS0-CrQTg@mail.gmail.com>
References:  <20110622020048.GA83940@FreeBSD.org> <BANLkTi=En%2B7nJgEmKCmBEQMwiV0nbcPhEg@mail.gmail.com> <20110622064224.GB94185@FreeBSD.org> <BANLkTi=s6zYOJJv6%2Bkk%2Bttd7jadmTuaT6w@mail.gmail.com> <20110622160233.8b6156e1.itetcu@FreeBSD.org> <20110622135941.GA99725@FreeBSD.org> <e645505a-06bd-461d-b4a6-3f4436caef24@email.android.com> <BANLkTim%2B46u3H9tUp-EqS1PKKtfKZ2KQTw@mail.gmail.com> <20110623033052.GA23118@FreeBSD.org> <BANLkTi=fiYsp-fJY97TkTyXWOCS0-CrQTg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 23, 2011 at 11:41:17AM +0400, Ilya A. Arkhipov wrote:
> Hi danfe@ marcus@
> 
> if I've got it right for group we need have specific order
> 
> +	&checkorder('LICENSE', $tmp, $file, qw(
> +LICENSE LICENSE_COMB LICENSE_PERMS LICENSE_GROUPS
> +LICENSE_NAME LICENSE_FILE LICENSE_TEXT+	));
> what you say if we do that?

This is excerpt from x11/nvidia-driver Makefile, which I think uses natural
order of LICENSE knobs:

LICENSE=        NVIDIA
LICENSE_NAME=   License For Customer Use of NVIDIA Software
LICENSE_FILE=   ${WRKSRC}/doc/license.txt
LICENSE_PERMS=  dist-mirror no-dist-sell pkg-mirror no-pkg-sell auto-accept

I would probably suggest this order:

  LICENSE
  LICENSE_COMB
  LICENSE_GROUPS
  LICENSE_NAME
  LICENSE_TEXT
  LICENSE_FILE
  LICENSE_PERMS

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110623083351.GA51681>