From owner-dev-commits-ports-all@freebsd.org Thu Apr 15 20:45:42 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BBAD15D6CAB; Thu, 15 Apr 2021 20:45:42 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FLrvp4LhVz4qGW; Thu, 15 Apr 2021 20:45:42 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from ubik.madpilot.net (host-82-53-63-238.retail.telecomitalia.it [82.53.63.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 0223B26049; Thu, 15 Apr 2021 20:45:41 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Subject: Re: git: b3c7fff32af0 - main - sysutils/ansible-sshjail: New port To: Mateusz Piotrowski <0mp@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202104151800.13FI0R3i033069@gitrepo.freebsd.org> <5ce76d1a-ca79-6e84-376b-612805f317b6@FreeBSD.org> From: Guido Falsi Message-ID: Date: Thu, 15 Apr 2021 22:45:40 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2021 20:45:42 -0000 On 15/04/21 22:39, Mateusz Piotrowski wrote: > Hi, > > On 15/04/2021 21:46, Guido Falsi wrote: >> On 15/04/21 21:07, Mateusz Piotrowski wrote: >>> >>>> diff --git a/sysutils/ansible-sshjail/Makefile >>>> b/sysutils/ansible-sshjail/Makefile >>>> new file mode 100644 >>>> index 000000000000..73499357b2f0 >>>> --- /dev/null >>>> +++ b/sysutils/ansible-sshjail/Makefile >>>> @@ -0,0 +1,30 @@ >>>> +PORTNAME=    ansible-sshjail >>>> +DISTVERSION=    1.1.0-g20210107 >>> [snip] >>>> +GH_ACCOUNT=    austinhyde >>>> +GH_TAGNAME=    981674f >>> Perhaps GH_TAGNAME could be replaced with DISTVERSION* variables based > on the output of git >>> describe --tags which is "v1.1.0-30-g981674f". >>> >> >> Is there a specific advantage to this approach? >> >> I did what I've been doing with other ports and also what I see >> documented in the porter's handbook. >> > There are a couple of advantages: > > 1. There is only one block of variables you need to edit in case of an > update. > > 2. DISTVERSION=1.1.0-30 becomes PORTVERSION=1.1.0.30. As a result, you > don't have to worry about increasing the date manually. Also, if you > happen to update the port twice to newer commit on a single day, you > don't have to come up with a workaround for 1.1.0-g20210107. The > DISTVERSION will just naturally increase from 1.1.0-30 to, e.g., 1.1.0-31. > > In fact, this is described in the FreeBSD Porter's Handbook in Example > 5.14. Using USE_GITHUB to Access a Commit Between Two Versions. The > gYYYYMMDD is reserved for cases when there is no single version tagged > by upstream (as explained in Example 5.13. Using USE_GITHUB When > Upstream Does Not Use Versions). > Ok you almost got me convinced, I'll do some testing and evaluate changing approach. -- Guido Falsi