Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Feb 2014 09:45:19 +0100
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Ruslan Makhmatkhanov <cvs-src@yandex.ru>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Alex Kozlov <ak@FreeBSD.org>, Xin LI <delphij@FreeBSD.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r345165 - head/devel/hgsvn
Message-ID:  <20140220084519.GB1699@ithaqua.etoilebsd.net>
In-Reply-To: <5305BF40.90003@yandex.ru>
References:  <201402192351.s1JNplot033193@svn.freebsd.org> <20140219235746.GA1699@ithaqua.etoilebsd.net> <5305BF40.90003@yandex.ru>

next in thread | previous in thread | raw e-mail | index | archive | help

--xXmbgvnjoT4axfJE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 20, 2014 at 12:39:28PM +0400, Ruslan Makhmatkhanov wrote:
> Baptiste Daroussin wrote on 20.02.2014 03:57:
>=20
> [...]
>=20
> >>   USE_PYTHON=3D	yes
> >>   USE_PYDISTUTILS=3Dyes
> >> +USE_ZIP=3D	yes
> >>   PYDISTUTILS_AUTOPLIST=3D	yes
> >>   PLIST_SUB=3D	VERSION=3D${PORTVERSION} PYVER=3D${PYTHON_VERSION:S/pyt=
hon//}
> >
> > Why readding USE_ZIP? while bsdtar can just extract it fine?
>=20
> Bapt, I already asked this, but got no response. ak@ made a patch to=20
> make USE_ZIP conditionally depend on unzip on a systems with old bsdtar.=
=20
> But it was never committed and pending portmgr@ approval. What the=20
> reason of this? What makes .zip so special, that we can't use this nice=
=20
> knob for it, but rather forced to construct pure ugliness with EXTRACT_SU=
FX?
>=20
> Thank you.
>=20
> PS. mat@ argued that it fails to deal with some of the zip-archives out=
=20
> there, but ak@ then said that he had no problems with any .zip's since=20
> libarchive 3.0.4.
>=20

kientzle@ told me that there are still some infozip are not supported.
Plus our unzip command it not compatible 100% with info zip one, thus slowly
removing the bsdtar, I'm all open for a better solution that USE_ZIP (which=
 I
personnaly find as ugly as EXTRACT_SUFX :)

Any proposition would be great, note that having this not relying unzip(1) =
but
using bsdtar(1) is better to support older freebsd without libarchive 3.0.4

regards,
Bapt

--xXmbgvnjoT4axfJE
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (FreeBSD)

iEYEARECAAYFAlMFwJ8ACgkQ8kTtMUmk6Ez3KQCffe1OQoAd4arjF89Klcz8Oyzn
ynQAn2E+D0RX9TWF1XVZhZQucvchUVxJ
=NviQ
-----END PGP SIGNATURE-----

--xXmbgvnjoT4axfJE--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140220084519.GB1699>