Date: Mon, 23 Jun 2003 11:55:53 -0700 (PDT) From: Nate Lawson <nate@root.org> To: current@freebsd.org Cc: Isaac Waldron <iwaldron@wpi.edu> Subject: Re: ACPI Patch/DSDT .asl for Dell Inspiron 5000 Message-ID: <20030623114844.Y67869@root.org>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-759531312-1056394553=:67869 Content-Type: TEXT/PLAIN; charset=US-ASCII Thanks for your patch submission. I looked into it and found a few problems. Attached is a patch based on yours that should be equivalent but fixes a few problems: * Don't call msleep if event has already occurred * Don't read CSR twice if not necessary (also fixed in EcEventWait) * Unused loop variable removed And same as yours: * 1 us wait added before first EC_STATUS read * A single call of msleep with 10 ms timeout is now used Please try the patch and see if it works for you. -Nate --0-759531312-1056394553=:67869 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="ec.diff" Content-Transfer-Encoding: BASE64 Content-ID: <20030623115553.S67869@root.org> Content-Description: Content-Disposition: attachment; filename="ec.diff" SW5kZXg6IGFjcGlfZWMuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNT IGZpbGU6IC9ob21lL25jdnMvc3JjL3N5cy9kZXYvYWNwaWNhL2FjcGlfZWMu Yyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjkNCmRpZmYgLXUgLXIxLjI5 IGFjcGlfZWMuYw0KLS0tIGFjcGlfZWMuYwkyNyBOb3YgMjAwMiAxODowOToy MCAtMDAwMAkxLjI5DQorKysgYWNwaV9lYy5jCTIzIEp1biAyMDAzIDE4OjQ2 OjAwIC0wMDAwDQpAQCAtNjE2LDcgKzYxNiw2IEBADQogRWNXYWl0RXZlbnRJ bnRyKHN0cnVjdCBhY3BpX2VjX3NvZnRjICpzYywgRUNfRVZFTlQgRXZlbnQp DQogew0KICAgICBFQ19TVEFUVVMJRWNTdGF0dXM7DQotICAgIGludAkJaTsN CiANCiAgICAgQUNQSV9GVU5DVElPTl9UUkFDRV9VMzIoKGNoYXIgKikodWlu dHB0cl90KV9fZnVuY19fLCAoVUlOVDMyKUV2ZW50KTsNCiANCkBAIC02Mjgs MjggKzYyNywzMyBAQA0KIAlBQ1BJX1ZQUklOVChzYy0+ZWNfZGV2LCBhY3Bp X2RldmljZV9nZXRfcGFyZW50X3NvZnRjKHNjLT5lY19kZXYpLA0KIAkgICAg IkVjV2FpdEV2ZW50SW50ciBjYWxsZWQgd2l0aG91dCBFQyBsb2NrIVxuIik7 DQogDQorICAgIC8qDQorICAgICAqIFN0YWxsIGZvciAxIG1pY3Jvc2Vjb25k IGJlZm9yZSByZWFkaW5nIHRoZSBzdGF0dXMgcmVnaXN0ZXINCisgICAgICog Zm9yIHRoZSBmaXJzdCB0aW1lLiAgVGhpcyBhbGxvd3MgdGhlIEVDIHRvIHNl dCB0aGUgSUJGL09CRg0KKyAgICAgKiBiaXQgdG8gaXRzIHByb3BlciBzdGF0 ZS4NCisgICAgICovDQorICAgIEFjcGlPc1N0YWxsKDEpOw0KICAgICBFY1N0 YXR1cyA9IEVDX0dFVF9DU1Ioc2MpOw0KKyAgICBpZiAoKEV2ZW50ID09IEVD X0VWRU5UX09VVFBVVF9CVUZGRVJfRlVMTCAmJg0KKwkoRWNTdGF0dXMgJiBF Q19GTEFHX09VVFBVVF9CVUZGRVIpICE9IDApIHx8DQorCShFdmVudCA9PSBF Q19FVkVOVF9JTlBVVF9CVUZGRVJfRU1QVFkgJiYgDQorCShFY1N0YXR1cyAm IEVDX0ZMQUdfSU5QVVRfQlVGRkVSKSA9PSAwKSkNCisJICAgIHJldHVybihB RV9PSyk7DQogDQotICAgIC8qIFhYWCB3YWl0aW5nIHRvbyBsb25nPyAqLw0K LSAgICBmb3IoaSA9IDA7IGkgPCAxMDsgaSsrKXsNCi0JLyoNCi0JICogQ2hl Y2sgRUMgc3RhdHVzIGFnYWluc3QgdGhlIGRlc2lyZWQgZXZlbnQuDQotCSAq Lw0KLSAgICAJaWYgKChFdmVudCA9PSBFQ19FVkVOVF9PVVRQVVRfQlVGRkVS X0ZVTEwpICYmDQotCSAgICAoRWNTdGF0dXMgJiBFQ19GTEFHX09VVFBVVF9C VUZGRVIpKQ0KLQkgICAgcmV0dXJuX0FDUElfU1RBVFVTKEFFX09LKTsNCi0g ICAgICANCi0JaWYgKChFdmVudCA9PSBFQ19FVkVOVF9JTlBVVF9CVUZGRVJf RU1QVFkpICYmIA0KLQkgICAgIShFY1N0YXR1cyAmIEVDX0ZMQUdfSU5QVVRf QlVGRkVSKSkNCi0JICAgIHJldHVybl9BQ1BJX1NUQVRVUyhBRV9PSyk7DQot CQ0KLQlzYy0+ZWNfY3NydmFsdWUgPSAwOw0KLQlpZiAoQUNQSV9NU0xFRVAo JnNjLT5lY19jc3J2YWx1ZSwgJmFjcGlfbXV0ZXgsIFBaRVJPLCAiRWNXYWl0 IiwgMSkgIT0gRVdPVUxEQkxPQ0spew0KLQkgICAgRWNTdGF0dXMgPSBzYy0+ ZWNfY3NydmFsdWU7DQotCX1lbHNlew0KLQkgICAgRWNTdGF0dXMgPSBFQ19H RVRfQ1NSKHNjKTsNCi0JfQ0KKyAgICAvKiBXYWl0IHVwIHRvIDEwbXMgZm9y IHRoZSBFQyBzdGF0dXMgdG8gaW5kaWNhdGUgY29tcGxldGlvbi4gKi8NCisg ICAgc2MtPmVjX2NzcnZhbHVlID0gMDsNCisgICAgaWYgKEFDUElfTVNMRUVQ KCZzYy0+ZWNfY3NydmFsdWUsICZhY3BpX211dGV4LCBQWkVSTywgIkVjV2Fp dCIsIGh6IC8gMTAwKQ0KKyAgICAgICAgIT0gRVdPVUxEQkxPQ0spIHsNCisJ RWNTdGF0dXMgPSBzYy0+ZWNfY3NydmFsdWU7DQorICAgIH0gZWxzZSB7DQor CUVjU3RhdHVzID0gRUNfR0VUX0NTUihzYyk7DQogICAgIH0NCisgICAgaWYg KChFdmVudCA9PSBFQ19FVkVOVF9PVVRQVVRfQlVGRkVSX0ZVTEwgJiYNCisJ KEVjU3RhdHVzICYgRUNfRkxBR19PVVRQVVRfQlVGRkVSKSAhPSAwKSB8fA0K KwkoRXZlbnQgPT0gRUNfRVZFTlRfSU5QVVRfQlVGRkVSX0VNUFRZICYmIA0K KwkoRWNTdGF0dXMgJiBFQ19GTEFHX0lOUFVUX0JVRkZFUikgPT0gMCkpDQor CSAgICByZXR1cm4oQUVfT0spOw0KKw0KICAgICByZXR1cm5fQUNQSV9TVEFU VVMoQUVfRVJST1IpOw0KIH0NCiANCkBAIC02NjksMTEgKzY3Myw4IEBADQog ICAgICAqIFN0YWxsIGZvciAxIG1pY3Jvc2Vjb25kIGJlZm9yZSByZWFkaW5n IHRoZSBzdGF0dXMgcmVnaXN0ZXINCiAgICAgICogZm9yIHRoZSBmaXJzdCB0 aW1lLiAgVGhpcyBhbGxvd3MgdGhlIEVDIHRvIHNldCB0aGUgSUJGL09CRg0K ICAgICAgKiBiaXQgdG8gaXRzIHByb3BlciBzdGF0ZS4NCi0gICAgICoNCi0g ICAgICogWFhYIGl0IGlzIG5vdCBjbGVhciB3aHkgd2UgcmVhZCB0aGUgQ1NS IHR3aWNlLg0KICAgICAgKi8NCiAgICAgQWNwaU9zU3RhbGwoMSk7DQotICAg IEVjU3RhdHVzID0gRUNfR0VUX0NTUihzYyk7DQogDQogICAgIC8qDQogICAg ICAqIFdhaXQgRm9yIEV2ZW50Og0KQEAgLTY4NCwxMyArNjg1LDExIEBADQog ICAgIGZvciAoaSA9IDA7IGkgPCAxMDAwOyBpKyspIHsNCiAJRWNTdGF0dXMg PSBFQ19HRVRfQ1NSKHNjKTsNCiANCi0gICAgICAgIGlmICgoRXZlbnQgPT0g RUNfRVZFTlRfT1VUUFVUX0JVRkZFUl9GVUxMKSAmJg0KLSAgICAgICAgICAg IChFY1N0YXR1cyAmIEVDX0ZMQUdfT1VUUFVUX0JVRkZFUikpDQotCSAgICBy ZXR1cm4oQUVfT0spOw0KLQ0KLQlpZiAoKEV2ZW50ID09IEVDX0VWRU5UX0lO UFVUX0JVRkZFUl9FTVBUWSkgJiYgDQotICAgICAgICAgICAgIShFY1N0YXR1 cyAmIEVDX0ZMQUdfSU5QVVRfQlVGRkVSKSkNCi0JICAgIHJldHVybihBRV9P Syk7DQorCWlmICgoRXZlbnQgPT0gRUNfRVZFTlRfT1VUUFVUX0JVRkZFUl9G VUxMICYmDQorCSAgICAoRWNTdGF0dXMgJiBFQ19GTEFHX09VVFBVVF9CVUZG RVIpICE9IDApIHx8DQorCSAgICAoRXZlbnQgPT0gRUNfRVZFTlRfSU5QVVRf QlVGRkVSX0VNUFRZICYmIA0KKwkgICAgKEVjU3RhdHVzICYgRUNfRkxBR19J TlBVVF9CVUZGRVIpID09IDApKQ0KKwkgICAgICAgIHJldHVybihBRV9PSyk7 DQogCQ0KIAlBY3BpT3NTdGFsbCgxMCk7DQogICAgIH0NCg== --0-759531312-1056394553=:67869--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030623114844.Y67869>