From owner-freebsd-net@FreeBSD.ORG  Fri Mar 19 11:54:20 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 857A8106566B;
	Fri, 19 Mar 2010 11:54:20 +0000 (UTC)
	(envelope-from ermal.luci@gmail.com)
Received: from mail-ww0-f54.google.com (mail-ww0-f54.google.com [74.125.82.54])
	by mx1.freebsd.org (Postfix) with ESMTP id EB26C8FC19;
	Fri, 19 Mar 2010 11:54:19 +0000 (UTC)
Received: by wwb18 with SMTP id 18so1842465wwb.13
	for <multiple recipients>; Fri, 19 Mar 2010 04:54:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:from:date:message-id
	:subject:to:cc:content-type;
	bh=0n4Q3Q/ahphvdHggRD9NN33WXrfg9j4Yg+8bdxUgYZk=;
	b=mppNGlHtlhAC67EY5U43ckfMqN5pZrJutkMbTKq8PYvdo1YlKcgar4NtNIw2yEj6g2
	KkSyGX2YpD/PfejKllHQHMJ3AbF1i+KWBzza26H3t5Iyrl+vgzT46LaMcaEih/2Yls7F
	zEG16z+D1xP0uQJEOsbNJF7UXy9JRudsbQFp0=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:from:date:message-id:subject:to:cc:content-type;
	b=lFN/UTpc3ziKTzdHfeajGsVPa0/qAcD2Yu7142Rh/HxAbwt2EpupSby/ML/LTbFPio
	dHG2h9vJ+FGCBDQkXxSCEw3Oo/vFpqRYokxoZr0NlfonpQxeWIZjq3+dEJiNhPMW82i6
	eWdtMVt5224Cei2akxSoTHYaPSuljwmTVEWHs=
MIME-Version: 1.0
Received: by 10.216.86.3 with SMTP id v3mr765073wee.190.1268999658143; Fri, 19 
	Mar 2010 04:54:18 -0700 (PDT)
From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <ermal.luci@gmail.com>
Date: Fri, 19 Mar 2010 12:53:58 +0100
Message-ID: <9a542da31003190453s1e7598efr8f35f525871f5589@mail.gmail.com>
To: freebsd-net <freebsd-net@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "Bjoern A. Zeeb" <bz@freebsd.org>
Subject: Is this correct?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Mar 2010 11:54:20 -0000

Shouldn't this check be
 if (m->m_len > sizeof (struct ip)) {
instead of
 if (m->m_len < sizeof (struct ip)) {

in
http://fxr.watson.org/fxr/source/netipsec/ipsec.c?im=excerpts#L595

Regards,
-- 
Ermal