From owner-freebsd-ports@FreeBSD.ORG Mon Jun 11 13:17:38 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5EBA41065672; Mon, 11 Jun 2012 13:17:38 +0000 (UTC) (envelope-from m.seaman@infracaninophile.co.uk) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) by mx1.freebsd.org (Postfix) with ESMTP id B143B8FC0A; Mon, 11 Jun 2012 13:17:37 +0000 (UTC) Received: from seedling.black-earth.co.uk (seedling.black-earth.co.uk [81.187.76.163]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.14.5/8.14.5) with ESMTP id q5BDHTlc080224 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 11 Jun 2012 14:17:29 +0100 (BST) (envelope-from m.seaman@infracaninophile.co.uk) X-DKIM: OpenDKIM Filter v2.5.2 smtp.infracaninophile.co.uk q5BDHTlc080224 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infracaninophile.co.uk; s=201001-infracaninophile; t=1339420649; bh=5Q90XzreCJX/EivwpsM5GWJipTbyht0t37eTv1t8hds=; h=Date:From:To:CC:Subject:References:In-Reply-To:Content-Type: Message-ID:Mime-Version; b=y3ghpGQOELz3DdiFzyt8S8f8HdFtcBsmaQKjrTLRuBUnXmoErU2G3oQG0B4Ai1/6f 7fc1LSXg46HExXpPu6VgyEFawVFyPExIHld8bp/AJ5YikM1jG9R51tQHz0BpTHjwZs 6WmUIvEOQC2PmBy0lfDltPQfVtJAmVQSEyFjk6xk= Message-ID: <4FD5EFE1.30200@infracaninophile.co.uk> Date: Mon, 11 Jun 2012 14:17:21 +0100 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120601 Thunderbird/13.0 MIME-Version: 1.0 To: Baptiste Daroussin References: <20120611043001.GO60433@ithaqua.etoilebsd.net> <4FD591DF.3060808@infracaninophile.co.uk> <20120611103221.GU60433@ithaqua.etoilebsd.net> <4FD5D7B8.9080504@infracaninophile.co.uk> <20120611115529.GV60433@ithaqua.etoilebsd.net> In-Reply-To: <20120611115529.GV60433@ithaqua.etoilebsd.net> X-Enigmail-Version: 1.4.2 OpenPGP: id=60AE908C Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig76A27F98D701ABB48E1B2102" X-Virus-Scanned: clamav-milter 0.97.4 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_ADSP_ALL,DKIM_SIGNED,T_DKIM_INVALID autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lucid-nonsense.infracaninophile.co.uk Cc: ports@freebsd.org Subject: Re: ports need a uniq identifier, do you have any suggestion? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2012 13:17:38 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig76A27F98D701ABB48E1B2102 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 11/06/2012 12:55, Baptiste Daroussin wrote: > why because they recommand their user to set PKGNAMEPREFIX to > ${BLA_PKGNAMEPREFIX} so that their prefix can be set from bsd.port.mk > Which mean that until the said bsd.$guilty.mk is included UNIQUENAME na= me is set > to ${PKGNAMEPREFIX}${PORTNAME} with PKGNAMEPREFIX being expanded to not= hing > and once bsd.$guilty.mk is included ${PKGNAMEPREFIX} expands to somethi= ng and so > UNIQUENAME is changed. (btw also break the options framework (old and n= ew) with > the ports because OPTIONSFILE is created using the ${UNIQUENAME} A light dawns. Yes. The value of $OPTIONSFILE cannot depend on anything that happens in the port after bsd.port.options.mk is .include'd= =2E How about this (untested): % cvs diff cvs diff: Diffing . Index: bsd.options.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/ports/Mk/bsd.options.mk,v retrieving revision 1.13 diff -u -r1.13 bsd.options.mk --- bsd.options.mk 6 Jun 2012 11:47:29 -0000 1.13 +++ bsd.options.mk 11 Jun 2012 13:03:47 -0000 @@ -8,8 +8,6 @@ # global ones and ending with the ones decided by the maintainer. # Options global to the entire ports tree -OPTIONSFILE?=3D ${PORT_DBDIR}/${UNIQUENAME}/options - #ALL_OPTIONS=3D DOCS \ # NLS Index: bsd.port.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.727 diff -u -r1.727 bsd.port.mk --- bsd.port.mk 8 Jun 2012 19:52:39 -0000 1.727 +++ bsd.port.mk 11 Jun 2012 13:06:35 -0000 @@ -1268,6 +1268,10 @@ UNIQUENAME?=3D ${PKGNAMEPREFIX}${PORTNAME} .endif +.if !defined(OPTIONSFILE) +OPTIONSFILE:=3D ${PORT_DBDIR}/${UNIQUENAME}/options +.endif + .endif DOS2UNIX_REGEX?=3D .* So OPTIONSFILE is at least independent of any changes to PKGNAMEPREFIX made by bsd.$guilty.mk? Port maintainers wishing to override the default OPTIONSFILE setting should obviously do that before the inclusion of bsd.port.options.mk Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard Flat 3 PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate JID: matthew@infracaninophile.co.uk Kent, CT11 9PW --------------enig76A27F98D701ABB48E1B2102 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/V7+kACgkQ8Mjk52CukIxVNACfS+TWU9IXe1zXGndPPI6deAwB t6oAnAj0QLyT+OwvUMkdtjpkMIgCRCvo =Y8tI -----END PGP SIGNATURE----- --------------enig76A27F98D701ABB48E1B2102--