Date: Tue, 24 Jun 2003 11:20:31 -0700 (PDT) From: Julian Elischer <julian@elischer.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin Makefile src/usr.sbin Makefile Message-ID: <Pine.BSF.4.21.0306241117500.93424-100000@InterJet.elischer.org> In-Reply-To: <20030624155351.GB6651@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
hmm well it seems to work fine...
how about I just fix the problems you have?
On Tue, 24 Jun 2003, Ruslan Ermilov wrote:
> On Tue, Jun 24, 2003 at 06:25:24AM -0700, Julian Elischer wrote:
> > julian 2003/06/24 06:25:24 PDT
> >
> > FreeBSD src repository
> >
> > Modified files:
> > usr.bin Makefile
> > usr.sbin Makefile
> > Log:
> > Connect bluetooth tools for i386 only.
> > These are probably machine independent, but
> > there is no way for the developers to test them other than on x86.
> >
> > They will become MD as testing becomes possible.
> >
> > Revision Changes Path
> > 1.241 +2 -0 src/usr.bin/Makefile
> > 1.258 +2 -0 src/usr.sbin/Makefile
> >
> Please back this out. The makefiles underneath that are not ready
> to be connected to the source tree; I've sent you and Maksim the
> patch that cleans this up (before the latest import), but I never
> heard back any feedback. Here's one example where this creates a
> problem:
This is the first I've heard of any problems..
they certainly seem to work fine..
Testing prtoduced the expoected files in the expected places..
If you see a problem send me the complete list and I'll fix it.
>
> : # $Id: Makefile,v 1.3 2003/03/24 23:59:49 max Exp $
>
> $Id$'s on makefiles are bogus, and especially that Maksim agreed
> developing against FreeBSD repository.
>
> : # $FreeBSD: src/usr.bin/bluetooth/btsockstat/Makefile,v 1.2 2003/05/10 21:44:42 julian Exp $
> :
> : PROG= btsockstat
> : BINGRP= kmem
> : BINMODE= 2555
> : MAN1= btsockstat.1
> :
> MAN1 is spelled MAN nowadays.
>
> : DESTDIR= /usr/bin/
> : MANDIR= ../share/man/man
> :
> These two are a real problem.
>
> : WARNS?= 2
> : CFLAGS+= -g -I${.CURDIR}/../../../sys/netgraph/bluetooth/include/
> :
> -g should not be in CFLAGS. -I to access bluetooth includes are bogus,
> and you also have the patch for that.
>
> : SRCS= btsockstat.c
> : DPADD= ${LIBKVM}
> : LDADD= -lkvm
> :
> : .include <bsd.prog.mk>
>
>
> Cheers,
> --
> Ruslan Ermilov Sysadmin and DBA,
> ru@sunbay.com Sunbay Software Ltd,
> ru@FreeBSD.org FreeBSD committer
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0306241117500.93424-100000>