From owner-svn-src-all@freebsd.org Fri Mar 10 19:12:46 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 730BAD067D1; Fri, 10 Mar 2017 19:12:46 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 408531A97; Fri, 10 Mar 2017 19:12:46 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pg0-x243.google.com with SMTP id g2so6731466pge.2; Fri, 10 Mar 2017 11:12:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2zS5xWdN5eurobaIPSX1m3K3QOn6Yv2E+j665OYoc0E=; b=UkCbkUjrETyskmLHBiJ/SeL+sO3hG4J7ISvnjR/I3Pb2YqmtxFchXKt+pxuyu5hdwp /wnP4aZlpN5eHm3wFWVv5X9jCKbenhzlCMPimbzgW3YWzr9hxC5kHGBoHpNmGm3qh9t1 aV0AXq3wnO47f/1a7yaaQUsEdK7S6ZcPk1BUH9KoY74KYzPWmxrnyWZCYEx4BDncwP8f GyAan4FlLCjEYqVmCQ4tq2L1RaTuDSpq+aPOXawYqE//1QCUStt3Oot2+UIF5rDZID8U eniXzJ4YKMlr6aX3jnxeamVkptbYkzWmA2NdMBhHvf7dkG89uMa0PNGhfE5sWA5SFOce ZTOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2zS5xWdN5eurobaIPSX1m3K3QOn6Yv2E+j665OYoc0E=; b=eUXlvs6k1lbc6TlDUMNTQPyDGnI7uxs814AsdxmUL9CCiXPgsT8+gVRBNpf4bhC5OU ri3aOQtSuX+EvwAa72x/iz1VUcM0nqDtPJGg3SakYeSx3Z3ZZAcfBT4vZpOOwOfYJGOg WfuS0+Zyk2L0lNxvb1vv53Z0FujZyK8ETJZRGnGy8Y5tzBx/7hr95cmMJ+lA6kV8T793 BzZlfnByx3Wya9bbS4ymL/azZwIe+2KziZI8C74gNoOGq2JgRP1KWzOCFKU34BaQt8nH 9fkOsy5o3d5doRDf2T2Rt9qlJGvJqJOhaMaPUZJuNtA5dwsBoXkAeSzQkpAp6fLmJEp6 kR6A== X-Gm-Message-State: AMke39lULp40pfMNVXzUa/fg6YHiQSeGzz0wgyL9kDY5g2rxu3uRj2JPhUJA6iM72SrT5sKfWr531/dxOkmIhw== X-Received: by 10.98.75.221 with SMTP id d90mr23014048pfj.107.1489173165728; Fri, 10 Mar 2017 11:12:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.182.172 with HTTP; Fri, 10 Mar 2017 11:12:45 -0800 (PST) In-Reply-To: References: <201701100323.v0A3NMAI045868@repo.freebsd.org> <20170215100637.2xsyyu46odzig4c4@dhcp-3-221.uk.xensource.com> From: Navdeep Parhar Date: Fri, 10 Mar 2017 11:12:45 -0800 Message-ID: Subject: Re: svn commit: r311849 - in head: . sys/amd64/conf sys/arm64/conf sys/conf sys/dev/e1000 sys/i386/conf sys/mips/conf sys/modules sys/modules/em sys/modules/igb sys/powerpc/conf To: Ryan Stone Cc: Warner Losh , Sean Bruno , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 19:12:46 -0000 On Fri, Mar 10, 2017 at 10:41 AM, Ryan Stone wrote: > There's also the issue that running "ifconfig igb0 blah" during startup w= ill > cause if_igb to be automatically loaded by ifconfig. > > I guess we could add a dummy if_igb.ko that just has a dependency on > if_em.ko I do similar stuff in cxgbe (if_cxl.ko and if_cc.ko exist solely to drag in if_cxgbe.ko as a dependency). In hindsight I wish I'd just added a list of ifnet names -> kld map to ifconfig instead. It would have been an ugly hack but much simpler. Regards, Navdeep > > On Fri, Mar 10, 2017 at 1:13 PM, Warner Losh wrote: >> >> On Fri, Mar 10, 2017 at 11:06 AM, Sean Bruno wrote: >> > >> > >> > On 02/15/17 03:06, Roger Pau Monn=C3=A9 wrote: >> >> On Tue, Jan 10, 2017 at 03:23:22AM +0000, Sean Bruno wrote: >> >>> Author: sbruno >> >>> Date: Tue Jan 10 03:23:22 2017 >> >>> New Revision: 311849 >> >>> URL: https://svnweb.freebsd.org/changeset/base/311849 >> >>> >> >>> Log: >> >>> Migrate e1000 to the IFLIB framework: >> >>> - em(4) igb(4) and lem(4) >> >>> - deprecate the igb device from kernel configurations >> >>> - create a symbolic link in /boot/kernel from if_em.ko to if_igb.k= o >> >> >> >> This linking causes mfsBSD to choke when building an image from HEAD. >> >> It tries >> >> to issue the following command: >> >> >> >> ${_v}${CP} -rp ${_BOOTDIR}/kernel ${WRKDIR}/disk/boot >> >> >> >> Which fails when finding the symbol link. I can send a patch to chang= e >> >> that to >> >> -Rp, which would work fine, but wouldn't it be better to either >> >> completely >> >> remove if_igb.ko, or simply copy if_em.ko to if_igb.ko? >> >> >> >> I'm wondering if for example anyone strips down it's /boot/kernel/ >> >> manually, by >> >> removing unused modules, and what would happen if if_em.ko is removed >> >> but not >> >> if_igb.ko. >> >> >> >> Roger. >> >> >> >> >> > >> > Well, this was my naive attempt to make upgrades for users to be >> > non-eventful in the event they have "if_igb_load=3DYES" in their >> > loader.conf instead of having it built into their kernel. >> > >> > If the -Rp works, I'll add that instead. >> >> The module name is encoded in the module itself. The boot loader looks >> it up to see which module to load. Maybe there's a way to fix it so >> both load from one file? >> >> Warner >> >