Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 May 2013 11:16:28 +0400
From:      Boris Samorodov <bsam@passap.ru>
To:        Jason Helfman <jgh@FreeBSD.org>
Cc:        "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Boris Samorodov <bsam@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>
Subject:   Re: svn commit: r319003 - head/mail/imaptools
Message-ID:  <51A0654C.4010204@passap.ru>
In-Reply-To: <CAMuy=%2BiSbFNWJee3oJ33i7%2BngTKCqeqJdaHKjo87-SuNkZoM5w@mail.gmail.com>
References:  <201305241819.r4OIJ4H8030590@svn.freebsd.org> <CAMuy=%2BiSbFNWJee3oJ33i7%2BngTKCqeqJdaHKjo87-SuNkZoM5w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
25.05.2013 00:59, Jason Helfman пишет:

> Can shebangfix from Mk/Uses be employed here?

Thanks for suggestion, I did not realise that it may be employed
here! However after some invesigation it seems it's not worth,
since a single reinplace command should be replaced by for knobs:
USES+SHEBANG_FILES as well as WRKSRC and NO_BUILD:
-----
Index: Makefile
===================================================================
--- Makefile    (revision 319012)
+++ Makefile    (working copy)
@@ -16,12 +16,12 @@

 CONFLICTS=     imaputils-[0-9]*

+WRKSRC=                ${WRKDIR}
+USES=          shebangfix
+SHEBANG_FILES= *.pl
+NO_BUILD=      yes
 USE_PERL5_RUN= yes

-do-build:
-       ${REINPLACE_CMD} \
-               -e 's|/usr/bin/perl|${PERL}|g' ${WRKDIR}/*.pl
-
 do-install:
        ${INSTALL_SCRIPT} ${WRKDIR}/*.pl ${PREFIX}/bin

-----

What do you think? What benefits are to use the shebangfix here?
-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51A0654C.4010204>