From owner-freebsd-acpi@FreeBSD.ORG Sun Jun 21 17:06:23 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86248106566C for ; Sun, 21 Jun 2009 17:06:23 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27]) by mx1.freebsd.org (Postfix) with ESMTP id 0E85B8FC15 for ; Sun, 21 Jun 2009 17:06:22 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by ey-out-2122.google.com with SMTP id 9so272248eyd.7 for ; Sun, 21 Jun 2009 10:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=rGDHBDvQpdYTUWOkyqhljJNJFnshZnx0gG+4b4BagOo=; b=koPYQPjRyp41FqINdAY67KnufpYWvwBk/ZL6EVJXDBKCCk4KGPyiyciq+2Jees8aZe RBBeZpoTF/9ay0BW+tXtr5VCVoJ6l/wrUY/ugq30sRofknYboO+esGsYRapPd7PAscdQ LnBOLm0/z1hTfl62O1s+9NiUUAxZodvbYd9ZQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=O4kPouGIwVXNb9koXQMAIc8NxWpeFjUO6lt9ISiM/4urwZIrlhThRxk35GN7Uxa8Fi 1mnwzE0UmTy6hkZYvdenV+3xnphVco3KL9p2qFOQSuY4lYxlblUV8v1TWKZMBa5qmgyr Uj2SqQfqYPOu7Ex4+CycONPGO1EFf3Cnxyqc0= Received: by 10.210.42.20 with SMTP id p20mr6091943ebp.92.1245603578443; Sun, 21 Jun 2009 09:59:38 -0700 (PDT) Received: from omega.lan (bl9-155-202.dsl.telepac.pt [85.242.155.202]) by mx.google.com with ESMTPS id 24sm266437eyx.13.2009.06.21.09.59.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 21 Jun 2009 09:59:38 -0700 (PDT) Sender: Rui Paulo Message-Id: <8F2C596E-1B49-4E15-ACC0-84C1A14BD245@freebsd.org> From: Rui Paulo To: Michael In-Reply-To: <4A3E6563.7040400@bindone.de> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Sun, 21 Jun 2009 17:59:36 +0100 References: <4A3E1784.2050406@bindone.de> <5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org> <4A3E6563.7040400@bindone.de> X-Mailer: Apple Mail (2.935.3) Cc: freebsd-acpi@freebsd.org Subject: Re: Two new acpi modules, acpi_wmi and acpi_hp X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jun 2009 17:06:23 -0000 On 21 Jun 2009, at 17:52, Michael wrote: > Rui Paulo wrote: >> On 21 Jun 2009, at 15:08, Rui Paulo wrote: >> >>> On 21 Jun 2009, at 12:20, Michael wrote: >>> >>>> Hello, >>>> >>>> I wrote two new acpi modules last year and finally found the time >>>> to fix >>>> them, add some missing features and write man pages. >>> >>> Michael, this is great work! I'll review and see if we can ship it >>> with 8.0! >> >> Michael, this looks good, but there are two style nits that we need >> to fix. >> * we should try not going over the 80 column mark >> * add a empty new line before every return >> >> If you could send me a new patch for 8.0 with these fixes, I'll >> commit >> it (unless someone else has objections). >> >> Regards, >> -- >> Rui Paulo >> > > Hi Rui, > > I figured that adding newlines in conditional returns makes no sense > (see my last post), so I did reformat everything to be (close to) 80 > columns a line add added newlines in front of returns at the end of a > function. Yeah, forget about the newlines before return. > Please find attached the complete patch again (against clean > 7.2-RELEASE) and the files that changed (acpi_hp.c and acpi_wmi.c). Can you send it in MIME format or store it at some webserver so I could fetch it? > Btw, what is the normal adoption path for 7-STABLE (I would assume > first > it gets into HEAD and if there's interest there will be a backport > to 7? > It should at least work in there, even so for HP laptops my guess is > that most users will use 8 anyway because of wireless support). It first goes into 8.0 and then 7-STABLE. Thanks, -- Rui Paulo