From owner-freebsd-current@FreeBSD.ORG Sun Jul 15 20:04:25 2012 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E14A1065670; Sun, 15 Jul 2012 20:04:25 +0000 (UTC) (envelope-from lars@e-new.0x20.net) Received: from mail.0x20.net (mail.0x20.net [217.69.76.211]) by mx1.freebsd.org (Postfix) with ESMTP id F16098FC12; Sun, 15 Jul 2012 20:04:24 +0000 (UTC) Received: from mail.0x20.net (mail.0x20.net [217.69.76.211]) by mail.0x20.net (Postfix) with ESMTP id C07086A6018; Sun, 15 Jul 2012 22:04:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at mail.0x20.net Received: from mail.0x20.net ([217.69.76.211]) by mail.0x20.net (mail.0x20.net [217.69.76.211]) (amavisd-new, port 10024) with ESMTP id Pydl7K2qcG4a; Sun, 15 Jul 2012 22:04:23 +0200 (CEST) Received: from e-new.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.0x20.net (Postfix) with ESMTPS id 75BD76A6016; Sun, 15 Jul 2012 22:04:23 +0200 (CEST) Received: from e-new.0x20.net (localhost [127.0.0.1]) by e-new.0x20.net (8.14.5/8.14.5) with ESMTP id q6FK4Nkd048794; Sun, 15 Jul 2012 22:04:23 +0200 (CEST) (envelope-from lars@e-new.0x20.net) Received: (from lars@localhost) by e-new.0x20.net (8.14.5/8.14.5/Submit) id q6FK4Msh048293; Sun, 15 Jul 2012 22:04:22 +0200 (CEST) (envelope-from lars) Date: Sun, 15 Jul 2012 22:04:22 +0200 From: Lars Engels To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= Message-ID: <20120715200422.GZ90853@e-new.0x20.net> References: <86obnif10y.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O2g7+miYGsIKoR9l" Content-Disposition: inline In-Reply-To: <86obnif10y.fsf@ds4.des.no> X-Editor: VIM - Vi IMproved 7.3 X-Operation-System: FreeBSD 8.3-RELEASE-p2 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "Justin T. Gibbs" , current@FreeBSD.org Subject: Re: PAM passwdqc, strict aliasing, and WARNS X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2012 20:04:25 -0000 --O2g7+miYGsIKoR9l Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 15, 2012 at 12:09:17AM +0200, Dag-Erling Sm=C3=B8rgrav wrote: > "Justin T. Gibbs" writes: > > Someone who has yet to confess added -Werror to the global CFLAGS > > (via /etc/make.conf) for one of our systems at work. Before I > > figured out that this was the cause of builds failing, I hacked up > > pam_passwdc to resolve the problem. This gets the module to > > WARNS=3D2, but to go farther, the "logically const" issues with this > > code will need to be sorted out. > > > > Is this change worth committing? Is this the best way to resolve > > the strict aliasing issues in this code? >=20 > I really don't like that sort of game. If you look at other PAM > consumer code, you'll see that the common idiom is what Jilles > suggested, i.e. use a temporary variable of the appropriate type. >=20 > That being said, pam_passwdqc should probably be either updated or > removed. The version we have is ten years old. But it still works... --O2g7+miYGsIKoR9l Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlADIkYACgkQKc512sD3afiC/gCfWZcu6Dfr8X1VKUFYUc5/7hKf 5dAAoK05ROMSoqFUnOvPhetqtlocTCTa =lp0f -----END PGP SIGNATURE----- --O2g7+miYGsIKoR9l--