From owner-freebsd-fs@freebsd.org Mon Jun 3 22:15:38 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD8B315BF964 for ; Mon, 3 Jun 2019 22:15:38 +0000 (UTC) (envelope-from pen@lysator.liu.se) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ADD90720C3 for ; Mon, 3 Jun 2019 22:15:36 +0000 (UTC) (envelope-from pen@lysator.liu.se) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 5C8D840004; Tue, 4 Jun 2019 00:15:28 +0200 (CEST) Received: from [192.168.1.79] (h-99-68.A785.priv.bahnhof.se [158.174.99.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 2DEB940002; Tue, 4 Jun 2019 00:15:28 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: RFC: should an incremental reload of exports for mountd be optional? From: Peter Eriksson In-Reply-To: Date: Tue, 4 Jun 2019 00:15:27 +0200 Cc: "freebsd-fs@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Rick Macklem X-Mailer: Apple Mail (2.3445.104.11) X-Virus-Scanned: ClamAV using ClamSMTP X-Rspamd-Queue-Id: ADD90720C3 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dmarc=pass (policy=none) header.from=liu.se; spf=pass (mx1.freebsd.org: domain of pen@lysator.liu.se designates 130.236.254.3 as permitted sender) smtp.mailfrom=pen@lysator.liu.se X-Spamd-Result: default: False [-2.23 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.lysator.liu.se]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_IN_DNSWL_MED(-0.20)[3.254.236.130.list.dnswl.org : 127.0.11.2]; MX_GOOD(-0.01)[v-mailfilter03.sunet.se,e-mailfilter04.sunet.se,v-mailfilter03.sunet.se,e-mailfilter04.sunet.se,v-mailfilter03.sunet.se,e-mailfilter04.sunet.se,v-mailfilter03.sunet.se,e-mailfilter04.sunet.se]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.72)[-0.720,0]; DMARC_POLICY_ALLOW(-0.50)[liu.se,none]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:2843, ipnet:130.236.0.0/16, country:SE]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.995,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.00)[country: SE(-0.01)] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 22:15:39 -0000 My vote goes to: Enabled by default (with an option to disable it in case problems pop = up). - Peter > On 31 May 2019, at 23:50, Rick Macklem wrote: >=20 > Hi, >=20 > I have created a patch for PR#237860 that improves the time it takes = to reload > the exports file(s) for an NFS file server from seconds->milliseconds = by only doing > system calls for the changes to the exports file(s). (Assumes each = reload includes > changes to only a small fraction of the entries.) >=20 > I made it a non-default option of "-I", but asomers@ asked why it = needed to be > optional. >=20 > Basically, I made it optional because I felt the patch might still be = buggy and not > handle some case of an exports file change that I missed. >=20 > However, I can see the argument of making it non-optional (or optional = but enabled > by default) so that sysadmins don't need to add "-I" to avoid long = periods where the > nfsd threads are suspended. > If it is broken, the deamon would need to be restarted to do a full = reload, but that > would also be the case if a sysadmin specified the "-I" option. >=20 > So, the question is... "do you think this should be an option or just = always enabled?". >=20 > Thanks , rick > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org"