Date: Tue, 22 Jan 2019 13:12:57 -0500 From: Mark Johnston <markj@freebsd.org> To: Ian Lepore <ian@freebsd.org> Cc: Brooks Davis <brooks@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343305 - head/sys/net Message-ID: <20190122181257.GA81189@raichu> In-Reply-To: <f2e1c8577fcb3726d97b3254635804007037859f.camel@freebsd.org> References: <201901221739.x0MHdQps047360@repo.freebsd.org> <f2e1c8577fcb3726d97b3254635804007037859f.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 22, 2019 at 10:45:16AM -0700, Ian Lepore wrote: > On Tue, 2019-01-22 at 17:39 +0000, Brooks Davis wrote: > > Author: brooks > > Date: Tue Jan 22 17:39:26 2019 > > New Revision: 343305 > > URL: https://svnweb.freebsd.org/changeset/base/343305 > > > > Log: > > Rework CASE_IOC_IFGROUPREQ() to require a case before the macro. > > > > This is more compatible with formatting tools and looks more > > normal. > > > > Reported by: jhb (on a different review) > > Sponsored by: DARPA, AFRL > > Differential Revision: https://reviews.freebsd.org/D18442 > > > > Modified: > > head/sys/net/if.c > > > > Modified: head/sys/net/if.c > > ===================================================================== > > ========= > > --- head/sys/net/if.c Tue Jan 22 17:34:53 2019 (r343304) > > +++ head/sys/net/if.c Tue Jan 22 17:39:26 2019 (r343305) > > @@ -168,14 +168,14 @@ struct ifmediareq32 { > > #define SIOCGIFXMEDIA32 _IOC_NEWTYPE(SIOCGIFXMEDIA, struct > > ifmediareq32) > > > > #define _CASE_IOC_IFGROUPREQ_32(cmd) > > \ > > - case _IOC_NEWTYPE((cmd), struct ifgroupreq32): > > + _IOC_NEWTYPE((cmd), struct ifgroupreq32): case > > That 'case' at the end of the line doesn't look right. With the change, CASE_IOC_IFGROUPREQ(cmd) yields case <cmd>32: case <cmd>: which seems to be the intent.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190122181257.GA81189>