Date: Mon, 12 Sep 2016 13:00:03 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Sepherosa Ziehau <sephe@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305722 - head/sys/x86/x86 Message-ID: <20160912100003.GX38409@kib.kiev.ua> In-Reply-To: <CAMOc5cww0TPqCV=_fLrvovYgCdV09abh5n2=BOATu-qHLYXj3g@mail.gmail.com> References: <201609120457.u8C4vw9S052665@repo.freebsd.org> <20160912083228.GW38409@kib.kiev.ua> <CAMOc5cxNTDuR-QvOqC4esCY=waFb2s%2BAFvMxbQrRnab=bmSG%2Bw@mail.gmail.com> <CAMOc5cww0TPqCV=_fLrvovYgCdV09abh5n2=BOATu-qHLYXj3g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 12, 2016 at 04:47:35PM +0800, Sepherosa Ziehau wrote: > On Mon, Sep 12, 2016 at 4:39 PM, Sepherosa Ziehau <sephe@freebsd.org> wrote: > > On Mon, Sep 12, 2016 at 4:32 PM, Konstantin Belousov > > <kostikbel@gmail.com> wrote: > >> On Mon, Sep 12, 2016 at 04:57:58AM +0000, Sepherosa Ziehau wrote: > >>> Author: sephe > >>> Date: Mon Sep 12 04:57:58 2016 > >>> New Revision: 305722 > >>> URL: https://svnweb.freebsd.org/changeset/base/305722 > >>> > >>> Log: > >>> x86: Use sx lock for interrupt sources. > >>> > >>> - Certain pic_assign_cpu, e.g. msi_assign_cpu can have quite a long > >>> call chain. For msi_assign_cpu, mutex makes complex PCI bridge > >>> drivers more tricky, e.g. sleep can note be called, etc, it will > >>> be pretty tricky for upcoming Hyper-V PCI bridge driver for PCI > >>> pass-through. > >> > >>> - It is not used on any hot code path nor non-sleepable context, so > >>> sx should have the same effect as mutex. > >> Did you tested ACPI_DMAR interrupt remapping mode with your patch and > >> witness enabled ? > > > > Nope, I am about to try it now. BTW, I just checked the code for > > ACPI_DMAR, I didn't see anything obviously w/ the lock type change > > though. > > I didn't notice anything wrong w/ options > ACPI_DMAR+WITNESS+INVARIANTS. If you saw anything wrong, please let > me know. Options are not enough, you should explicitely enable interrupt remapping with loader tunable hw.dmar.ir=1.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160912100003.GX38409>