From owner-freebsd-stable@FreeBSD.ORG Sat Aug 21 20:08:34 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76AE61065672 for ; Sat, 21 Aug 2010 20:08:34 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 3518E8FC08 for ; Sat, 21 Aug 2010 20:08:33 +0000 (UTC) Received: from outgoing.leidinger.net (p57B3AB23.dip.t-dialin.net [87.179.171.35]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 4B20B84400C; Sat, 21 Aug 2010 21:51:01 +0200 (CEST) Received: from unknown (unknown [192.168.2.110]) by outgoing.leidinger.net (Postfix) with ESMTP id 53D0F154C; Sat, 21 Aug 2010 21:50:55 +0200 (CEST) Date: Sat, 21 Aug 2010 21:50:52 +0200 From: Alexander Leidinger To: jhell Message-ID: <20100821215052.000030f1@unknown> In-Reply-To: <4C6F5344.6040808@DataIX.net> References: <4C6F5344.6040808@DataIX.net> X-Mailer: Claws Mail 3.7.2cvs15 (GTK+ 2.16.0; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 4B20B84400C.A2CF8 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-0.923, required 6, autolearn=disabled, ALL_TRUSTED -1.00, TW_ZF 0.08) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1283025062.59047@ewcJUXyabt8vWtDJtFf4KQ X-EBL-Spam-Status: No Cc: FreeBSD Stable Subject: Re: daily run output 800.scrub-zfs fixups X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2010 20:08:34 -0000 On Sat, 21 Aug 2010 00:17:08 -0400 jhell wrote: > > Hi Alexander, > > Attached is a fix for one problem and one slight overlook for > 800.scrub-zfs. > > The first & second change was probably just an oversight but none the > less they both give a false impression of actions taken. > > Change1: > ${daily_scrub_zfs_default_threshold=30} is missng the ':' > which would ultimately reset the users supplied value in > periodic.conf to 30. I will have a look at this. > Change2: > ${_scrub_diff} -le ${_pool_threshold} would cause the scrub > to be run on the day after the threshold was met. So I changed '-le' > -> '-lt' which causes it to be run on the 30th day instead of the > 31st day. This depends how you define threshold... I had number of days between scrubs in my mind. Now it depends what I wrote in the man page, if it tells what I had in mind (I don't remember, I have to look at it myself, but I'm not a native english speaker, so I may have not wrote it good enough). This is not set in stone, if the majority of people want something else, I'm surely not in the way. Bye, Alexander. > -------- Original Message -------- > Subject: xxxxxx.dataix.local daily run output > Date: Fri, 20 Aug 2010 03:18:09 -0400 (EDT) > From: Superuser Root > To: root@xxxxxx.dataix.local > > ...snip... > > Scrubbing of zfs pools: > skipping scrubbing of pool 'exports': > last scrubbing is 30 days ago, threshold is set to 30 days > > -- End of daily output -- >