Date: Mon, 19 Jul 2010 22:22:20 +0000 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: Doug Barton <dougb@freebsd.org> Cc: ports@freebsd.org, Mark Linimon <linimon@lonesome.com>, perl@freebsd.org, skv@freebsd.org, jhell <jhell@DataIX.net> Subject: Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk) Message-ID: <4C44D01C.70704@p6m7g8.com> In-Reply-To: <4C43B4A5.5080104@FreeBSD.org> References: <20100718223830.GA10338@lonesome.com> <4C43B4A5.5080104@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I've long been interested in this. I must be using the wrong options or something. About 1 yr ago I was able to build the index after removing the appropriate things in Mk/. On 07/19/10 02:12, Doug Barton wrote: > On 07/18/10 15:38, Mark Linimon wrote: >> The intention of bsd.perl.mk was to eventually allow a bunch of code >> to be pulled out of bsd.port.mk, and to have bsd.perl.mk only included >> conditionally, on the theory that it will speed up INDEX building >> somewhat. (I have not tested for speedup). > > Sounds like something that should be tested. > >> The problem is that there are N ports that assume that the logic in >> bsd.perl.mk is always available. I've tried to convince people that >> these are bugs, but OTOH if you leave out one of these definitions >> such as USE_PERL5 or PERL_CONFIGURE, and _PERL_REFACTORING_COMPLETE >> is defined, then INDEX breaks. > > I'm confused. Are you saying that there are ports that try to use stuff > that's defined in bsd.perl.mk without including it? If so, that should > be fixed. > > Also, how many ports are we talking about here? What is duplicated > between .mk files? Is there an easy algorithm to determine this? > >> Every once in a while I try to put in patches to force N to zero, but >> then I get stuck on wierd edge cases. This is why the switch has not >> been thrown. > > Step 1: Fix the easy cases > Step 2: Notify maintainers of wacky edge cases (perhaps followed by a > brief delay to let them fix it themselves) > Step 2: Disconnect broken wacky edge cases from the build > Step 3: Reconnect wacky edge cases as they get fixed > > At bare minimum Step 1 should be followed immediately to avoid people > copy/pasting bad examples. > >> Every time I try to work on this, "something happens" and it gets >> shoved on the back-burner for several months. This has been going >> on for several years now ... > > Then it's way beyond time you asked for help. :) I've cc'ed perl@ in > case they are interested in this. If not, I might be. > >> At this point it may be better to just do the following: >> >> - unconditionally include bsd.perl.mk and get rid of the code >> duplication that is in bsd.port.mk. > > Um, no. That's 100% backwards. If you're going to include it > unconditionally there is no point in having a separate file. But I don't > think that including it unconditionally is the right answer, it would be > better to fix this properly. > > > Doug > - -- - ------------------------------------------------------------------------ 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. System Admin, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iD8DBQFMRNAcdbiP+9ubjBwRAtS3AJ9rCBCA3u3N7QEoiov5qfHTBXVVCQCgjtEr j47qDeZUTQrqFZpVCdiFXEU= =kroi -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C44D01C.70704>