From owner-freebsd-arch@FreeBSD.ORG Sun May 9 03:25:23 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8F53E106564A; Sun, 9 May 2010 03:25:23 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.221.175]) by mx1.freebsd.org (Postfix) with ESMTP id 393538FC08; Sun, 9 May 2010 03:25:22 +0000 (UTC) Received: by qyk5 with SMTP id 5so4289351qyk.3 for ; Sat, 08 May 2010 20:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:cc:content-type; bh=lAckO1A3q5DjSJZti1Hpq2YmfmvzMCEbvMS54IA52MA=; b=hdOpW4ACc5wyHoWhK+h1kcLTpvIGuu6e/xO6mDsdOHT7Bvllw7wypc3nvscla71MkB 0AjJf/UgC8LtulZA1gPIZHp6L//aT2fhYhHQKMXI8E2ZAYo8z4GIK5Mub3MZltQ78PVB N1BbbkHUk9wPc87inNWMldbbrXZ9vTt3sn7Fg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; b=FpqZMjvDJQ+25IC9wPEsft41i2apZffk+6i3V5EOQ/GV0oqcQ+5i47lhyWPfyvaRyT ZiG/p/CIesu21kEAAgN191cfTU50iuoOiyoGYQwr49b2R/2Ejz28NtW+Z0Ch6koJtkDE X6rMFj0J23VDXcKcMVKzbN28kVTKTyLLUVCVk= MIME-Version: 1.0 Received: by 10.229.239.4 with SMTP id ku4mr1630834qcb.86.1273375522395; Sat, 08 May 2010 20:25:22 -0700 (PDT) Received: by 10.229.193.14 with HTTP; Sat, 8 May 2010 20:25:22 -0700 (PDT) Date: Sat, 8 May 2010 20:25:22 -0700 Message-ID: From: Garrett Cooper To: portmgr@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Cc: arch@freebsd.org Subject: [RFC] Deprecate @srcdir in pkg_install manifests X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 May 2010 03:25:23 -0000 Hi Arch and Portmgr, Found another item that I'm proposing for removal -- @srcdir. Now, first off, here's what it does (from pkg_create): @srcdir directory Set the internal directory pointer for _creation only_ to directory. That is to say that it overrides @cwd for package creation but not extraction. This construct: 1. Isn't used anywhere in /usr/ports's pkg_plist* files. 2. Isn't used in /usr/src . 3. Is semi-broken in pkg_create as it's treated as a really awkward special case, like so: else if (p->type == PLIST_CWD || p->type == PLIST_SRC) fprintf(totar, "-C\n%s\n", p->name); So if I specify @srcdir multiple times, pkg_create will fall in on itself. 4. It over-complicates things, as the -p option basically already sort of provides this level of functionality; the only pro for doing this that I can think of is if someone had tainted vs untainted files that they wanted to install, then using @srcdir with a custom manifest and directory would simplify things. I argue that if they're doing that, they should be using a chroot or a jail anyhow because package maintainers would potentially unnecessarily taint the system with their environment and the packages wouldn't be necessarily as safe to redistribute. Another item I'll be talking about with flz and other folks at BSDCan, but I wanted to see if anyone had any concerns that they needed to air here before a final decision was made by portmgr. Thanks, -Garrett