Date: Fri, 21 Jun 2019 23:28:00 +0200 From: Christoph Moench-Tegeder <cmt@burggraben.net> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Christoph Moench-Tegeder <cmt@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504800 - in head/cad: . kicad-doc Message-ID: <20190621212800.GA2542@elch.exwg.net> In-Reply-To: <20190621145405.GA390@FreeBSD.org> References: <201906211352.x5LDq1E6071357@repo.freebsd.org> <20190621145405.GA390@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
## Alexey Dokuchaev (danfe@freebsd.org):
> Sorry, but I'm afraid it was badly reviewed.
We can fix that... and it's all on me.
> > +MAINTAINER= cmt@FreeBSD.org
> > +COMMENT= KiCad Online Documentation/Help Files
>
> Comment is confusing ("online" typically means one does not have to
> install anything locally, that makes it "offline")...
Not that I'm attached to "online" - but I was thinking "online docs" ==
"whatever you get with the built-in help function", and "offline docs"
are printed (or something to that tune). That may indicate that I'm
somewhat old. Whatever.
> > +++ head/cad/kicad-doc/pkg-descr Fri Jun 21 13:52:01 2019
> > @@ -0,0 +1,3 @@
> > +This port installs the official KiCad schematic symbol libraries.
>
> ... and does not align well with the port description.
Argh, thanks for spotting. Lost edit. But there's not much to this
port to describe, it's just the help files - it just felt "more right"
to have them as their own ports, as this thing alone is around 230MB
package file and built from it's own repository.
> > +PLIST_SUB= PORTDOCS=""
>
> Why not simply remove %%PORTDOCS%% from the pkg-plist if you're setting
> it to an empty value unconditionally?
Because I was holding it wrong, in some non-reproducable way. I was
getting empty packages until I found this hack - but now that I've made
an ass of myself, everything works again.
> > +NO_ARCH= yes
>
> This knob should appear earlier.
Where? I can't find it anywhere in "Order of Variables" (Ch. 15 of
the Porter's Handbook), so I was putting it at the end, as in "The
Rest of the Variables") and portlint didn't complain. And looking
at other ports, the situation is... not clear.
Regards,
Christoph
--
Spare Space
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190621212800.GA2542>