Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Aug 2015 19:04:49 +0930
From:      Shane Ambler <FreeBSD@ShaneWare.Biz>
To:        Carlos J Puga Medina <cpm@fbsd.es>, emorrasg@yahoo.es
Cc:        freebsd-questions <freebsd-questions@freebsd.org>
Subject:   Re: fetch a distribution file using the git commit
Message-ID:  <55E2CE39.5010102@ShaneWare.Biz>
In-Reply-To: <1440840184.30127.5.camel@fbsd.es>
References:  <1440840184.30127.5.camel@fbsd.es>

next in thread | previous in thread | raw e-mail | index | archive | help
On 29/08/2015 18:53, Carlos J Puga Medina wrote:
>> It works for me as expected, but is this line from the configuration
>> file? if yes, it should have "":
>
>> MASTER_SITES_tl-parser="
> https://codeload.github.com/vysheng/tl-parser/tar.gz/1659d87?dummy="
>
> No. The MASTER_SITES is set by GH_* variables.

That's not from the makefile, it is the output during the fetch stage.

> See for details:
> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfile
> s.html#makefile-master_sites-github
>
>> not found
>> *** Error code 127
>>
>> Here it is the relevant part in the Makefile
>> USE_GITHUB=     yes
>> GH_ACCOUNT=     vysheng
>> GH_PROJECT=     tgl:tgl tl-parser:tl-parser
>> GH_TAGNAME=     2.0.1:tgl 1659d87:tl-parser
>>

Yes using multiple github groups has been working for a couple of
months now and they had me stumped at first too, you need two small
changes.

The first is that you must use the default group, this is misleading as
the example in the porters handbook matches what you have done and the
non-github use of groups does not enforce a default group. In the
second paragraph to 5.4.3.1 it does say "The main value can either have
no tag, or the :DEFAULT tag" - so you should remove the usage of :tgl
- not specifying a group name implies :DEFAULT

The second issue is that the group name does not like the '-' sign in
the name. As detailed under 5.4.8.2 - "Elements can be postfixed with
:n where n is [^:,]+, that is, n could conceptually be any alphanumeric
string but we will limit it to [a-zA-Z_][0-9a-zA-Z_]+ for now."

This leads to the following to get it working -

USE_GITHUB=     yes
GH_ACCOUNT=     vysheng
GH_PROJECT=     tgl tl-parser:tlparser
GH_TAGNAME=     2.0.1 1659d87:tlparser


While the porters handbook has been updated since I suggested some
changes I think it could still be improved a little.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=172964

-- 
FreeBSD - the place to B...Software Developing

Shane Ambler




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55E2CE39.5010102>