Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 3 Jun 2017 23:12:16 -0700
From:      Conrad Meyer <cem@freebsd.org>
To:        Colin Percival <cperciva@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r319561 - head/usr.bin/primes
Message-ID:  <CAG6CVpWi1faxwgMP16ULENrht9Ba5C7zYRg3cGVze7KnVjnT-w@mail.gmail.com>
In-Reply-To: <201706040236.v542ac6c056561@repo.freebsd.org>
References:  <201706040236.v542ac6c056561@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Colin,

Minor nitpicking follows.

On Sat, Jun 3, 2017 at 7:36 PM, Colin Percival <cperciva@freebsd.org> wrote:
> Author: cperciva
> Date: Sun Jun  4 02:36:37 2017
> New Revision: 319561
> URL: https://svnweb.freebsd.org/changeset/base/319561
>
> Log:
>   Using results from
>       J. Sorenson and J. Webster, Strong pseudoprimes to twelve prime
>       bases, Math. Comp. 86(304):985-1003, 2017.
>   teach primes(6) to enumerate primes up to 2^64 - 1.  Until Sorenson
>   and Webster's paper, we did not know how many strong speudoprime tests
>   were required when testing alleged primes between 3825123056546413051
>   and 2^64 - 1.
> ...
> Modified: head/usr.bin/primes/primes.c
> ==============================================================================
> --- head/usr.bin/primes/primes.c        Sun Jun  4 02:21:38 2017        (r319560)
> +++ head/usr.bin/primes/primes.c        Sun Jun  4 02:36:37 2017        (r319561)
> @@ -120,7 +120,7 @@ main(int argc, char *argv[])
>         argv += optind;
>
>         start = 0;
> -       stop = SPSPMAX;
> +       stop = (uint64_t)(-1);

Isn't this usually spelled UINT64_MAX?

Best,
Conrad



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpWi1faxwgMP16ULENrht9Ba5C7zYRg3cGVze7KnVjnT-w>