Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Oct 2006 16:34:10 GMT
From:      Matt Jacob <mjacob@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 108354 for review
Message-ID:  <200610241634.k9OGYANn017302@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=108354

Change 108354 by mjacob@newisp on 2006/10/24 16:33:32

	Make fields broad enough to have > 16 seconds worth of
	(usec defined) timeouts.

Affected files ...

.. //depot/projects/newisp/dev/isp/isp.c#23 edit
.. //depot/projects/newisp/dev/isp/ispreg.h#7 edit

Differences ...

==== //depot/projects/newisp/dev/isp/isp.c#23 (text+ko) ====

@@ -3139,6 +3139,7 @@
 	mbs.param[6] = DMA_WD3(fcp->isp_scdma);
 	mbs.param[7] = DMA_WD2(fcp->isp_scdma);
 	mbs.logval = MBLOGALL;
+	mbs.timeout = 1000000;
 	isp_mboxcmd(isp, &mbs);
 	if (mbs.param[0] != MBOX_COMMAND_COMPLETE) {
 		if (mbs.param[0] == MBOX_INVALID_COMMAND) {
@@ -3786,6 +3787,7 @@
 	mbs.param[6] = DMA_WD3(fcp->isp_scdma);
 	mbs.param[7] = DMA_WD2(fcp->isp_scdma);
 	mbs.logval = MBLOGALL;
+	mbs.timeout = 1000000;
 	MEMORYBARRIER(isp, SYNC_SFORDEV, 0, SNS_RFT_ID_REQ_SIZE);
 	isp_mboxcmd(isp, &mbs);
 	FC_SCRATCH_RELEASE(isp);

==== //depot/projects/newisp/dev/isp/ispreg.h#7 (text+ko) ====

@@ -467,9 +467,9 @@
 	uint16_t param[MAILBOX_STORAGE];
 	uint16_t ibits;
 	uint16_t obits;
-	uint32_t
-	    	timeout : 28,
+	uint32_t	: 28,
 		logval	: 4;
+	uint32_t timeout;
 } mbreg_t;
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610241634.k9OGYANn017302>