Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Oct 2008 13:00:24 +0200
From:      Ed Schouten <ed@80386.nl>
To:        d@delphij.net
Cc:        FreeBSD Current <freebsd-current@freebsd.org>
Subject:   Re: [patch] fix build wrt ppbus
Message-ID:  <20081022110024.GI16837@hoeg.nl>
In-Reply-To: <48FEE8B0.7090906@delphij.net>
References:  <48FEE8B0.7090906@delphij.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--2KNN3gYh9MUZz6n4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Xin LI <delphij@delphij.net> wrote:
> Here is a patch which can (presumbly) fix ppbus build issue...  I don't
> think I'm familiar with the code enough so I'd like to seek review from
> someone else.

I think it's better to abuse si_drv0 to store this data, which is why I
used dev2unit(). In the very far future we could decide to get rid of
make_dev()'s unit number and expose si_drv0 directly to the driver,
which is why I think that approach would be best for now.

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--2KNN3gYh9MUZz6n4
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkj/B8gACgkQ52SDGA2eCwXrSgCeMf2Z5jUawMZh6+55BC2Etel7
ne4AnjhQzW9yN4Llci7EVVbLohW1aH3y
=3p/7
-----END PGP SIGNATURE-----

--2KNN3gYh9MUZz6n4--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081022110024.GI16837>