From owner-cvs-projects@FreeBSD.ORG Wed Dec 31 23:20:41 2003 Return-Path: Delivered-To: cvs-projects@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 38D0016A4CE; Wed, 31 Dec 2003 23:20:41 -0800 (PST) Received: from telecom.net.et (sparrow.telecom.net.et [213.55.64.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5CE3D43D62; Wed, 31 Dec 2003 23:20:12 -0800 (PST) (envelope-from mtm@identd.net) Received: from [213.55.65.66] (HELO pool-151-200-10-97.res.east.verizon.net) by telecom.net.et (CommuniGate Pro SMTP 3.4.8) with ESMTP-TLS id 33056006; Thu, 01 Jan 2004 10:14:48 +0300 Received: from mobile.acsolutions.com (localhost [127.0.0.1]) ESMTP id i017K5fU001058; Thu, 1 Jan 2004 10:20:07 +0300 (EAT) (envelope-from mtm@mobile.acsolutions.com) Received: (from mtm@localhost) by mobile.acsolutions.com (8.12.10/8.12.10/Submit) id i017K4Pp001057; Thu, 1 Jan 2004 10:20:04 +0300 (EAT) (envelope-from mtm) Date: Thu, 1 Jan 2004 10:20:02 +0300 From: Mike Makonnen To: Kris Kennaway Message-ID: <20040101072002.GA968@mobile.acsolutions.com> References: <200312311554.hBVFsmTp022013@repoman.freebsd.org> <20031231192152.GA11533@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031231192152.GA11533@xor.obsecurity.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD/5.2-CURRENT (i386) cc: projects-committers@FreeBSD.org cc: cvs-projects@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: projects/validate/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_timedlock 5-1.c 5-2.c 5-3.c X-BeenThere: cvs-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the projects tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jan 2004 07:20:41 -0000 On Wed, Dec 31, 2003 at 11:21:52AM -0800, Kris Kennaway wrote: > On Wed, Dec 31, 2003 at 07:54:48AM -0800, Mike Makonnen wrote: > > mtm 2003/12/31 07:54:48 PST > > > > FreeBSD projects repository > > > > Modified files: > > validate/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_timedlock > > 5-1.c > > 5-2.c > > 5-3.c > > Log: > > Correct incorrect assertion about the behaviour of pthread_mutex_timedlock() > > o If the thread has the mutex already locked it will not block. It > > will return EDEADLK. Therefore, according to the standard, > > returning EINVAL if the timeout is invalid does not apply to > > such a thread. > > > > Better explanation for the case testing for immediate return > > with ETIMEDOUT when the timeout is set to the current time. > > Isn't something a bit wrong with the testsuite if you have to make a > lot of commits to port it to freebsd? Heh. I knew someone was bound to bring this up. The testsuite was developed on a Linux box. So, most of the patches have to do with header inclusions and unimplemented or differing function signatures. Also keep in mind that the commits were/are being made to three separate parts: the testharness (Linux centric), tests developed for a Linux box, and Posix conformance tests. The only ones that should work right out of the box with FreeBSD are the POSIX tests. And most of those tests do work out of the box. Except for this one case most of the patching in this area is header inclusions. In this regard I am tring to be careful to fix the header inclusions in areas that don't affect the assertion that is being tested. Cheers. -- Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc mtm@identd.net | Fingerprint: 00E8 61BC 0D75 7FFB E4D3 6BF1 B239 D010 3215 D418 mtm@FreeBSD.Org| FreeBSD - Unleash the Daemon !