From owner-cvs-src@FreeBSD.ORG Thu Oct 2 16:15:16 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C510A10656A1; Thu, 2 Oct 2008 16:15:16 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 8E1638FC08; Thu, 2 Oct 2008 16:15:16 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m92GEuGW039383 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 2 Oct 2008 09:14:57 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <48E4F380.20408@freebsd.org> Date: Thu, 02 Oct 2008 09:14:56 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: John Hay References: <200809291627.m8TGRaat081340@repoman.freebsd.org> <20081002122511.GW16837@hoeg.nl> <20081002161046.GA5678@zibbi.meraka.csir.co.za> In-Reply-To: <20081002161046.GA5678@zibbi.meraka.csir.co.za> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-Misty-Metrics: ebb.errno.com; whitelist Cc: Ed Schouten , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Oct 2008 16:15:16 -0000 John Hay wrote: > On Thu, Oct 02, 2008 at 02:25:11PM +0200, Ed Schouten wrote: > >> Hello Sam, >> >> * Sam Leffler wrote: >> >>> sam 2008-09-29 16:27:32 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sbin/ifconfig ifconfig.c >>> Log: >>> SVN rev 183466 on 2008-09-29 16:27:32Z by sam >>> >>> Distinguish between cmd/parameters used for clone operations and >>> all others. Use this to disambiguate cmd line arguments that can >>> be either clone params or regular parameters so, in particular, >>> "bssid" again works as a regular parameter. >>> >>> While here leverage the above to improve the logic for flushing >>> clone operations on the first !clone cmd line parameter. >>> >>> Reviewed by: jhay >>> >> Is it possible that this commit broke `ifconfig foo vlan bar vlandev baz'? >> I just had to revert to an ifconfig, probably from September 22, to make >> my system work properly again. >> > > And if you try with "ifconfig foo create vlan bar vlandev baz"? I have > only tried it with the create keyword added and the clone stuff in > /etc/network.subr also use it like that, if I read the code correctly. > I think if it previously worked, it was by accident. :-/ If we need > it to work, maybe one can test for vlan in main() whith the test for > create or plumb? > > > Ah, I see now, the cmd that didn't work was using the parameters w/o a clone operation. It should work but is likely broke; will look at it. Sam