From owner-freebsd-stable@FreeBSD.ORG Wed Jan 16 18:01:02 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 4B9BF427; Wed, 16 Jan 2013 18:01:02 +0000 (UTC) (envelope-from kpaasial@gmail.com) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by mx1.freebsd.org (Postfix) with ESMTP id 90FFBEC2; Wed, 16 Jan 2013 18:01:01 +0000 (UTC) Received: by mail-wi0-f181.google.com with SMTP id hq4so1518190wib.2 for ; Wed, 16 Jan 2013 10:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=qZMkTwxHj3cSgS6b36hHfHNKgNFcgKn7+N9JLrEaJmI=; b=JQGWGmdzHEDKmtwySWPUAHdk2ksyWwMd5vIO+WZe1tzq3T1toizRp0eOkzVs441ODS PntBZSPlhZtyJprnXRaRdEPe/w5jHdKQKUF+QuK4RpSbhrEBILAyc+ICV5aW6H6tWHAS 8+YPVgfqXdpEvv3QaCbykBNber3uuGuDAdOKGOs5pgdDtrSgzb2TZEciH+8ve7b06YC0 YW/fcEZgD632oSM9DIJDZH98ehUWr3WnTocgD94KChKQRY9GM5WiEkzjZOKw8KqV0yhQ FxR/JZpyXoZoWel2bwxz5+idy8NKOuD/5oXSCW6Zsqlo5udMFYdZ8LUwAPPy55cWvlHN nMXg== MIME-Version: 1.0 X-Received: by 10.180.81.39 with SMTP id w7mr3805283wix.15.1358359260339; Wed, 16 Jan 2013 10:01:00 -0800 (PST) Received: by 10.216.172.197 with HTTP; Wed, 16 Jan 2013 10:01:00 -0800 (PST) In-Reply-To: <50F6D20A.6070306@FreeBSD.org> References: <50F6D20A.6070306@FreeBSD.org> Date: Wed, 16 Jan 2013 20:01:00 +0200 Message-ID: Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9 From: Kimmo Paasiala To: Dimitry Andric Content-Type: text/plain; charset=UTF-8 Cc: Brooks Davis , freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2013 18:01:02 -0000 On Wed, Jan 16, 2013 at 6:15 PM, Dimitry Andric wrote: > On 2013-01-16 13:05, Kimmo Paasiala wrote: >> >> I just updated my stable/9 system after clang3.2 was added. My system >> is amd64, both world and kernel are compiled with clang3.2 and the >> default compiler is clang. I'm tracking the sources with GIT and the >> version I have corresponds to SVN revision r245451. >> >> Everything else seems to work but the pam authentication module >> security/pam_ssh_agent_auth segfaults immediately. > > ... > >> #0 0x0000000800ef2070 in strsvis () from /lib/libc.so.7 >> #1 0x0000000800ef2584 in strvis () from /lib/libc.so.7 >> #2 0x0000000800ef25e5 in strnvis () from /lib/libc.so.7 >> #3 0x0000000801c0e2e7 in do_log () from >> /usr/local/lib/pam_ssh_agent_auth.so >> #4 0x0000000801c0e4ff in logit () from >> /usr/local/lib/pam_ssh_agent_auth.so > > ... > >> The str*vis() calls suggest that it's something in the libc maybe? > > > Brooks merged the new strvis implementations in r245439, so you may have > run into a bug with them. I don't think this is caused specifically by > clang, at least not without more proof. :-) > > Can you try reverting to the revision just before r245439, rebuilding > and reinstalling at least libc, and see if the pam_ssh_agent_auth crash > goes away? I'm rebuilding world now. Took me some time to figure out how to revert the commits in git. I'll report back once finished. -Kimmo