Date: Tue, 17 Dec 2013 05:29:33 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Adrian Chadd <adrian@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r259475 - head/sys/kern Message-ID: <20131217012933.GY29088@FreeBSD.org> In-Reply-To: <CAJ-VmokxmRqm=mVEHzDeQkKeWCRJatchpJGm93uDM8HyQ1wtew@mail.gmail.com> References: <201312161931.rBGJVOhs083409@svn.freebsd.org> <20131216204021.GW29088@FreeBSD.org> <CAJ-VmokxmRqm=mVEHzDeQkKeWCRJatchpJGm93uDM8HyQ1wtew@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 16, 2013 at 04:54:15PM -0800, Adrian Chadd wrote: A> Ok. I'll go find where I copy pastes thus from. The mbuf code perhaps? A> A> Should we do a big quick tidy up? Nope, the mbuf code is somewhat different, due to secondary zones. An item freed there isn't actually freed, that's why they need a shift of trashing memory not in ctor/dtor, but in init/fini. Actually, now I see that your code is not only extraneous but wrong. You probably wanted to set ctor/dtor methods, not init/fini. So just remove it, in case of INVARIANTS the UMA automatically does all needed trash filling and later checking. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131217012933.GY29088>