Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Mar 2013 14:53:44 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Boris Samorodov <bsam@passap.ru>
Cc:        svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r314859 - head/palm/jpilot
Message-ID:  <20130322145344.GA16844@FreeBSD.org>
In-Reply-To: <514C6DEF.10201@passap.ru>
References:  <201303211827.r2LIRHrh078301@svn.freebsd.org> <514C6DEF.10201@passap.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 22, 2013 at 06:42:55PM +0400, Boris Samorodov wrote:
> 21.03.2013 22:27, Baptiste Daroussin пишет:
> > --- head/palm/jpilot/Makefile	Thu Mar 21 18:25:04 2013	(r314858)
> > +++ head/palm/jpilot/Makefile	Thu Mar 21 18:27:17 2013	(r314859)
> [...]
> > -# "?=" and "+=" are for including this Makefile from japanese/jpilot
> 
> Not particular to this commit, but rather a general question:
> what is our current policy on comments at the makefile headers?
> I mean non-standard comments (maintainer tips, etc.). Should
> they be deleted?

I would not delete them (in general case).  In this particular case I assume
they were deleted because they were stating quite obvious thing: certain
variables with +=/?= are clear indication of master/slave relationship.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130322145344.GA16844>