Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Feb 2017 08:25:31 +0000 (UTC)
From:      Ngie Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r313468 - in projects/stable-10-backport-test-changes: contrib/netbsd-tests/lib/libc/c063 contrib/netbsd-tests/lib/libc/ssp lib/libc/tests/c063 lib/libc/tests/ssp
Message-ID:  <201702090825.v198PVS1045887@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Thu Feb  9 08:25:30 2017
New Revision: 313468
URL: https://svnweb.freebsd.org/changeset/base/313468

Log:
  MFC r276527,r277648:
  
  r276527:
  
  Don't install h_raw if dealing with clang 3.5.0+ to unbreak the tests2 Jenkins
  job
  
  The h_raw application doesn't do proper bounds checking without the option
  being supplied via the build, which means that it doesn't throw signals and
  fail as expected
  
  PR: 196430
  
  r277648 (by jilles):
  
  Enable utimensat tests from NetBSD.
  
  As with other tests from c063, a required #include <sys/stat.h> was missing.

Modified:
  projects/stable-10-backport-test-changes/contrib/netbsd-tests/lib/libc/c063/t_utimensat.c
  projects/stable-10-backport-test-changes/contrib/netbsd-tests/lib/libc/ssp/t_ssp.sh
  projects/stable-10-backport-test-changes/lib/libc/tests/c063/Makefile
  projects/stable-10-backport-test-changes/lib/libc/tests/ssp/Makefile
Directory Properties:
  projects/stable-10-backport-test-changes/   (props changed)

Modified: projects/stable-10-backport-test-changes/contrib/netbsd-tests/lib/libc/c063/t_utimensat.c
==============================================================================
--- projects/stable-10-backport-test-changes/contrib/netbsd-tests/lib/libc/c063/t_utimensat.c	Thu Feb  9 08:19:30 2017	(r313467)
+++ projects/stable-10-backport-test-changes/contrib/netbsd-tests/lib/libc/c063/t_utimensat.c	Thu Feb  9 08:25:30 2017	(r313468)
@@ -40,6 +40,9 @@ __RCSID("$NetBSD: t_utimensat.c,v 1.5 20
 #include <string.h>
 #include <unistd.h>
 #include <sys/param.h>
+#ifdef __FreeBSD__
+#include <sys/stat.h>
+#endif
 #include <sys/time.h>
 
 #define DIR "dir"

Modified: projects/stable-10-backport-test-changes/contrib/netbsd-tests/lib/libc/ssp/t_ssp.sh
==============================================================================
--- projects/stable-10-backport-test-changes/contrib/netbsd-tests/lib/libc/ssp/t_ssp.sh	Thu Feb  9 08:19:30 2017	(r313467)
+++ projects/stable-10-backport-test-changes/contrib/netbsd-tests/lib/libc/ssp/t_ssp.sh	Thu Feb  9 08:25:30 2017	(r313468)
@@ -361,6 +361,9 @@ raw_head()
 raw_body()
 {
 	prog="$(atf_get_srcdir)/h_raw"
+	# Begin FreeBSD
+	[ -x $prog ] || atf_skip "$prog is missing; skipping testcase"
+	# End FreeBSD
 
 	h_pass "$prog 9"
 	# Begin FreeBSD

Modified: projects/stable-10-backport-test-changes/lib/libc/tests/c063/Makefile
==============================================================================
--- projects/stable-10-backport-test-changes/lib/libc/tests/c063/Makefile	Thu Feb  9 08:19:30 2017	(r313467)
+++ projects/stable-10-backport-test-changes/lib/libc/tests/c063/Makefile	Thu Feb  9 08:25:30 2017	(r313468)
@@ -2,7 +2,7 @@
 
 TESTSDIR=	${TESTSBASE}/lib/libc/c063
 
-#TODO: t_o_search, t_utimensat
+#TODO: t_o_search
 
 NETBSD_ATF_TESTS_C=	faccessat_test
 NETBSD_ATF_TESTS_C+=	fchmodat_test
@@ -18,6 +18,7 @@ NETBSD_ATF_TESTS_C+=	readlinkat_test
 NETBSD_ATF_TESTS_C+=	renameat_test
 NETBSD_ATF_TESTS_C+=	symlinkat_test
 NETBSD_ATF_TESTS_C+=	unlinkat_test
+NETBSD_ATF_TESTS_C+=	utimensat
 
 CFLAGS+= -D_INCOMPLETE_XOPEN_C063
 

Modified: projects/stable-10-backport-test-changes/lib/libc/tests/ssp/Makefile
==============================================================================
--- projects/stable-10-backport-test-changes/lib/libc/tests/ssp/Makefile	Thu Feb  9 08:19:30 2017	(r313467)
+++ projects/stable-10-backport-test-changes/lib/libc/tests/ssp/Makefile	Thu Feb  9 08:25:30 2017	(r313468)
@@ -26,7 +26,11 @@ PROGS+=		h_getcwd
 PROGS+=		h_memcpy
 PROGS+=		h_memmove
 PROGS+=		h_memset
+# This testcase doesn't run properly when not compiled with -fsantize=bounds
+# with clang, which is currently contingent on a compiler_rt update
+.if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} < 30500
 PROGS+=		h_raw
+.endif
 PROGS+=		h_read
 PROGS+=		h_readlink
 PROGS+=		h_snprintf



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702090825.v198PVS1045887>