From owner-freebsd-ports@FreeBSD.ORG  Tue Jul 22 12:56:39 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id AC73637B401; Tue, 22 Jul 2003 12:56:39 -0700 (PDT)
Received: from gw.celabo.org (gw.celabo.org [208.42.49.153])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7B37843FA3; Tue, 22 Jul 2003 12:56:38 -0700 (PDT)
	(envelope-from nectar@celabo.org)
Received: from madman.celabo.org (madman.celabo.org [10.0.1.111])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "madman.celabo.org", Issuer "celabo.org CA" (verified OK))
	by gw.celabo.org (Postfix) with ESMTP
	id 18B3754846; Tue, 22 Jul 2003 14:56:38 -0500 (CDT)
Received: by madman.celabo.org (Postfix, from userid 1001)
	id 91F336D455; Tue, 22 Jul 2003 14:56:37 -0500 (CDT)
Date: Tue, 22 Jul 2003 14:56:37 -0500
From: "Jacques A. Vidrine" <nectar@FreeBSD.org>
To: Simon Barner <barner@in.tum.de>
Message-ID: <20030722195637.GC10922@madman.celabo.org>
References: <20030718025200.GA36893@rot13.obsecurity.org>
	<20030722122608.GC552@zi025.glhnet.mhn.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030722122608.GC552@zi025.glhnet.mhn.de>
X-Url: http://www.celabo.org/
User-Agent: Mutt/1.5.4i-ja.1
cc: ports@FreeBSD.org
cc: current@FreeBSD.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: Fixing gcc 3.3 compile failures -- fix for net/netsaint-plugins
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jul 2003 19:56:40 -0000

On Tue, Jul 22, 2003 at 02:26:08PM +0200, Simon Barner wrote:

> --- plugins/check_by_ssh.c.orig	Mon Apr 23 09:43:11 2001
> +++ plugins/check_by_ssh.c	Tue Jul 22 05:05:52 2003
> @@ -191,7 +191,7 @@
>  	if (commands>1)
>  		remotecmd=strscat(remotecmd,";echo STATUS CODE: $?;");
>  
> -	if (strlen (remotecmd) <= 1)
> +	if (remotecmd==NULL)
>  		usage ("No remotecmd\n");
>  
>  	comm = ssprintf(comm,"%s %s '%s'",comm,hostname,remotecmd);

This looks like more than a fix for a `compile failure'.  The
replacement code has different semantics than the new code.
What is the `compile failure' that was being fixed here?

Cheers,
-- 
Jacques Vidrine   . NTT/Verio SME      . FreeBSD UNIX       . Heimdal
nectar@celabo.org . jvidrine@verio.net . nectar@freebsd.org . nectar@kth.se