From owner-cvs-src@FreeBSD.ORG Tue May 22 13:20:34 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5AA3016A41F; Tue, 22 May 2007 13:20:34 +0000 (UTC) (envelope-from anderson@freebsd.org) Received: from mh2.centtech.com (moat3.centtech.com [64.129.166.50]) by mx1.freebsd.org (Postfix) with ESMTP id 22EC913C448; Tue, 22 May 2007 13:20:34 +0000 (UTC) (envelope-from anderson@freebsd.org) Received: from neutrino.centtech.com (neutrino.centtech.com [10.177.171.220]) by mh2.centtech.com (8.13.8/8.13.8) with ESMTP id l4MCukRK019364; Tue, 22 May 2007 07:56:46 -0500 (CDT) (envelope-from anderson@freebsd.org) Message-ID: <4652E88A.9080500@freebsd.org> Date: Tue, 22 May 2007 07:56:42 -0500 From: Eric Anderson User-Agent: Thunderbird 2.0.0.0 (X11/20070521) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= References: <200705211144.l4LBiEHY098477@repoman.freebsd.org> <200705211422.47842.jkim@FreeBSD.org> <86r6pagfic.fsf@dwp.des.no> <200705211548.46790.jkim@FreeBSD.org> <86myzygda0.fsf@dwp.des.no> In-Reply-To: <86myzygda0.fsf@dwp.des.no> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV 0.88.4/3281/Tue May 22 03:50:43 2007 on mh2.centtech.com X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=8.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.6 X-Spam-Checker-Version: SpamAssassin 3.1.6 (2006-10-03) on mh2.centtech.com Cc: Doug Barton , "Ralf S. Engelschall" , cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, Jung-uk Kim Subject: Re: cvs commit: src/etc/rc.d hostid X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2007 13:20:34 -0000 On 05/21/07 14:57, Dag-Erling Smørgrav wrote: > Jung-uk Kim writes: >> 'smbios.system.uuid' is exported from loader, not from kernel. And it >> already checks two things, i.e., all zero's and all 0xff's, which are >> the most common and 'useless' UUIDs. If the SMBIOS has one of these, >> it is not set at all. > > Is it safe to assume that smbios.system.uuid returns a string of the > correct form (the correct amount of hex digits with hyphens in the right > places) which is neither all-bits-zero nor all-bits-one? In that case, > there is no need to check anything in etc/rc.d/hostid. > > DES [picking random related post to reply to] The hostid script also is cranky when used on a diskless host, because it can't write to it's hostid file. I've been ignoring it, but I wanted to at least mention it. Shall I file a PR? Eric