From owner-freebsd-current@FreeBSD.ORG Tue Nov 7 17:39:25 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C121C16A539; Tue, 7 Nov 2006 17:39:25 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-2.cisco.com (sj-iport-2-in.cisco.com [171.71.176.71]) by mx1.FreeBSD.org (Postfix) with ESMTP id 169D043DC4; Tue, 7 Nov 2006 17:38:30 +0000 (GMT) (envelope-from rrs@cisco.com) Received: from sj-dkim-2.cisco.com ([171.71.179.186]) by sj-iport-2.cisco.com with ESMTP; 07 Nov 2006 09:38:21 -0800 Received: from sj-core-1.cisco.com (sj-core-1.cisco.com [171.71.177.237]) by sj-dkim-2.cisco.com (8.12.11.20060308/8.12.11) with ESMTP id kA7HcJDj000535; Tue, 7 Nov 2006 09:38:19 -0800 Received: from xbh-sjc-211.amer.cisco.com (xbh-sjc-211.cisco.com [171.70.151.144]) by sj-core-1.cisco.com (8.12.10/8.12.6) with ESMTP id kA7HcDAw027101; Tue, 7 Nov 2006 09:38:19 -0800 (PST) Received: from xfe-sjc-212.amer.cisco.com ([171.70.151.187]) by xbh-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 7 Nov 2006 09:38:19 -0800 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-212.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 7 Nov 2006 09:38:18 -0800 Message-ID: <4550C463.4020502@cisco.com> Date: Tue, 07 Nov 2006 12:37:39 -0500 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <20061104060421.6145773068@freebsd-current.sentex.ca> <200611061649.56193.jhb@freebsd.org> <454FD0CF.4030705@cisco.com> <200611071011.15597.jhb@freebsd.org> In-Reply-To: <200611071011.15597.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 07 Nov 2006 17:38:19.0045 (UTC) FILETIME=[83591550:01C70293] DKIM-Signature: a=rsa-sha1; q=dns; l=893; t=1162921099; x=1163785099; c=relaxed/simple; s=sjdkim2002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:Randall=20Stewart=20 |Subject:Re=3A=20[head=20tinderbox]=20failure=20on=20sparc64/sun4v; X=v=3Dcisco.com=3B=20h=3DdlYYRt/rc+u/Ae65nzXQdpNRGMA=3D; b=qFJn3MHfq7VYVddmEkrH9CJ+NaG+93kxqE0nBQLAlXnVwnQLG3xNbR/pn1bdlMTPwcNu0hA2 2XJ4hSrSAqUKgySiSf57LWXWgPs4pRKpWGPj0jEBxObFUd57Vh4XRLFd; Authentication-Results: sj-dkim-2.cisco.com; header.From=rrs@cisco.com; dkim=pass ( sig from cisco.com verified; ); Cc: current@freebsd.org, Peter Jeremy , sparc64@freebsd.org, FreeBSD Tinderbox , Kip Macy , John Birrell , freebsd-sparc64@freebsd.org Subject: Re: [head tinderbox] failure on sparc64/sun4v X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2006 17:39:26 -0000 John Baldwin wrote: > > What I mean there is that there is a simple refcount_*() API wrapper in > sys/refcount.h that uses atomic ops on ints to safely manage reference > counts, and I would prefer the code to use refcount_*() instead of > atomic_*() directly if it fits as atomics can be tricky to manage > sometimes. > I need to think on this a bit.. the code is common to several platforms.. and this will take a bit of fore-thought to make sure we get it right if we move to something else besides the atomic_xxxx ops. There are also some where we do similar things to what the mbuf cluster freeing does with atomic_cmpset... etc. Simple refcnt's won't help there.. there are others that are not so... let me look through the macro's and see what I can come up with :-) R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)