From owner-cvs-sys Tue Dec 16 08:38:51 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id IAA07883 for cvs-sys-outgoing; Tue, 16 Dec 1997 08:38:51 -0800 (PST) (envelope-from owner-cvs-sys) Received: from critter.freebsd.dk (critter.freebsd.dk [195.8.129.26]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id IAA07874; Tue, 16 Dec 1997 08:38:38 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost.cybercity.dk [127.0.0.1]) by critter.freebsd.dk (8.8.7/8.8.7) with ESMTP id RAA04072; Tue, 16 Dec 1997 17:34:05 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: dg@root.com cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_exec.c In-reply-to: Your message of "Tue, 16 Dec 1997 08:22:17 PST." <199712161622.IAA08136@implode.root.com> Date: Tue, 16 Dec 1997 17:34:04 +0100 Message-ID: <4070.882290044@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Well, considering that you say it came in around march this year I'd say something has protected us pretty well from it... Poul-Henning In message <199712161622.IAA08136@implode.root.com>, David Greenman writes: >>davidg 1997/12/16 07:40:31 PST >> >> Modified files: >> sys/kern kern_exec.c >> Log: >> Fix bug where a struct buf was free()'d back to the system malloc pool. >> Quite amazing that the system runs at all with this bug. Also present in >> 2.2.5. The bug appears to have come in with changes in rev 1.53. >> >> PR: might fix PR#5313 >> Submitted by: bde >> >> Revision Changes Path >> 1.70 +3 -4 src/sys/kern/kern_exec.c > > This log message is somewhat wrong. It's not the struct buf that was >being free()'d, but rather the buffer mapping/target of the struct buf (the >filesystem data). A serious bug nonetheless, and I can hardly imagine what >this might do to the system. > >-DG > >David Greenman >Core-team/Principal Architect, The FreeBSD Project > -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop."