From owner-freebsd-arch@FreeBSD.ORG Tue Sep 20 14:44:47 2005 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7FD2216A41F for ; Tue, 20 Sep 2005 14:44:47 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 201C743D45 for ; Tue, 20 Sep 2005 14:44:47 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Tue, 20 Sep 2005 11:00:34 -0400 From: John Baldwin To: freebsd-arch@freebsd.org Date: Tue, 20 Sep 2005 10:45:58 -0400 User-Agent: KMail/1.8 References: <5975.1127215219@critter.freebsd.dk> In-Reply-To: <5975.1127215219@critter.freebsd.dk> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200509201045.58685.jhb@FreeBSD.org> Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Cc: Poul-Henning Kamp Subject: Re: Improving bus/resource API X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2005 14:44:47 -0000 On Tuesday 20 September 2005 07:20 am, Poul-Henning Kamp wrote: > The patch below improves the bus/resource API such that between 10 > and 20 lines of code can be eliminated from the attach/detach > functions of the average device driver. > > Therefore the best place to start is to read what the patch does > to if_sis.c, which is a very typical case. > > The patch is backwards compatible in binary and source form so > it is a potential candidate for RELENG_6 at some point. > > Compile tested on i386/amd64 and sparc64. My alpha will be chewing > on it for the forseeable future. > > > For sanity in the ensuing bikeshed, let's take three topics in > this order: > > 1. "what this does to the device driver sources." > > 2. "what this does to the rman/bus internals" > > 3. "suggestions for different function names" I'll only comment on 3) Maybe bus_read_{1,2,4}() rather than bsr_? (Same with s/bsw_/bus_write_/). I do like having the accessors take just a resource rather than a tag, handle pair. Many drivers already hide this in wrapper macros already though. For the dwiw (dwim? :-P) maybe since it takes an array, just make the 'resource' part plural, thus 'bus_alloc_resources()' and 'bus_release_resources()'? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org