Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Dec 2015 08:24:54 +0000 (UTC)
From:      Andrew Rybchenko <arybchik@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r291847 - head/sys/dev/sfxge/common
Message-ID:  <201512050824.tB58Osus082984@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: arybchik
Date: Sat Dec  5 08:24:54 2015
New Revision: 291847
URL: https://svnweb.freebsd.org/changeset/base/291847

Log:
  sfxge: cleanup: remove set but not used variable with parse error indication
  
  Required to build with -Werror=unused-but-set-variable.
  Keep it under #if 0 as a reminder for parse error processing.
  
  Sponsored by:   Solarflare Communications, Inc.
  MFC after:      2 days

Modified:
  head/sys/dev/sfxge/common/hunt_ev.c

Modified: head/sys/dev/sfxge/common/hunt_ev.c
==============================================================================
--- head/sys/dev/sfxge/common/hunt_ev.c	Sat Dec  5 08:21:45 2015	(r291846)
+++ head/sys/dev/sfxge/common/hunt_ev.c	Sat Dec  5 08:24:54 2015	(r291847)
@@ -492,7 +492,9 @@ hunt_ev_rx(
 {
 	efx_nic_t *enp = eep->ee_enp;
 	uint32_t size;
+#if 0
 	boolean_t parse_err;
+#endif
 	uint32_t label;
 	uint32_t mcast;
 	uint32_t eth_base_class;
@@ -539,7 +541,10 @@ hunt_ev_rx(
 		flags |= EFX_PKT_CONT;
 	}
 
+#if 0
+	/* TODO What to do if the packet is flagged with parsing error */
 	parse_err = (EFX_QWORD_FIELD(*eqp, ESF_DZ_RX_PARSE_INCOMPLETE) != 0);
+#endif
 	label = EFX_QWORD_FIELD(*eqp, ESF_DZ_RX_QLABEL);
 
 	if (EFX_QWORD_FIELD(*eqp, ESF_DZ_RX_ECRC_ERR) != 0) {
@@ -623,7 +628,9 @@ hunt_ev_rx(
 
 	switch (l3_class) {
 	case ESE_DZ_L3_CLASS_RSVD7: /* Used by firmware for packet overrun */
+#if 0
 		parse_err = B_TRUE;
+#endif
 		flags |= EFX_DISCARD;
 		break;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201512050824.tB58Osus082984>