Date: Sat, 25 Apr 2020 13:03:37 +0000 (UTC) From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r360302 - in stable: 11/lib/libdevdctl 12/lib/libdevdctl Message-ID: <202004251303.03PD3bxW075767@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dim Date: Sat Apr 25 13:03:37 2020 New Revision: 360302 URL: https://svnweb.freebsd.org/changeset/base/360302 Log: MFC r355974 (by rlibby): libdevdctl: g++9 avoid Wdeprecated-copy g++9 now warns about having defined an assignment operator but using the default copy constructor, or vice versa. Avoid the issue in libdevdctl by just using the default assignment operator too. Reviewed by: asomers, dim Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D22887 Modified: stable/12/lib/libdevdctl/guid.h Directory Properties: stable/12/ (props changed) Changes in other areas also in this revision: Modified: stable/11/lib/libdevdctl/guid.h Directory Properties: stable/11/ (props changed) Modified: stable/12/lib/libdevdctl/guid.h ============================================================================== --- stable/12/lib/libdevdctl/guid.h Sat Apr 25 12:57:20 2020 (r360301) +++ stable/12/lib/libdevdctl/guid.h Sat Apr 25 13:03:37 2020 (r360302) @@ -70,9 +70,6 @@ class Guid (public) Guid(const std::string &guid); static Guid InvalidGuid(); - /* Assignment */ - Guid& operator=(const Guid& rhs); - /* Test the validity of this guid. */ bool IsValid() const; @@ -108,13 +105,6 @@ inline Guid Guid::InvalidGuid() { return (Guid(INVALID_GUID)); -} - -inline Guid& -Guid::operator=(const Guid &rhs) -{ - m_GUID = rhs.m_GUID; - return (*this); } inline bool
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004251303.03PD3bxW075767>